chrome/renderer/chrome_content_renderer_client_unittest.cc - Issue 2030013003: Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //chrome

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/chrome_content_renderer_client_unittest.cc

Issue 2030013003: Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/permissions/permission_set_unittest.cc ('k') | chrome/test/chromedriver/window_commands.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/chrome_content_renderer_client_unittest.cc

diff --git a/chrome/renderer/chrome_content_renderer_client_unittest.cc b/chrome/renderer/chrome_content_renderer_client_unittest.cc

index 6421223191a2a84a098d2235a292638a05590909..898916fbe7657a8be1d6a079058986f32b62f16a 100644

--- a/chrome/renderer/chrome_content_renderer_client_unittest.cc

+++ b/chrome/renderer/chrome_content_renderer_client_unittest.cc

@@ -110,7 +110,7 @@ scoped_refptr<const extensions::Extension> CreateTestExtension(

manifest.SetInteger("manifest_version", 2);

if (is_hosted_app) {

base::ListValue* url_list = new base::ListValue();

- url_list->Append(new base::StringValue(app_url));

+ url_list->AppendString(app_url);

manifest.Set(extensions::manifest_keys::kWebURLs, url_list);

manifest.SetString(extensions::manifest_keys::kLaunchWebURL, app_url);

}

« no previous file with comments | « chrome/common/extensions/permissions/permission_set_unittest.cc ('k') | chrome/test/chromedriver/window_commands.cc » ('j') | no next file with comments »