Index: chrome/browser/extensions/api/proxy/proxy_api_helpers_unittest.cc |
diff --git a/chrome/browser/extensions/api/proxy/proxy_api_helpers_unittest.cc b/chrome/browser/extensions/api/proxy/proxy_api_helpers_unittest.cc |
index b08192728bb5109202289101a029edc6627080f4..6dcf63a05241c0d1b70176eaea8963c8fd025006 100644 |
--- a/chrome/browser/extensions/api/proxy/proxy_api_helpers_unittest.cc |
+++ b/chrome/browser/extensions/api/proxy/proxy_api_helpers_unittest.cc |
@@ -206,8 +206,8 @@ TEST(ExtensionProxyApiHelpers, GetBypassListFromExtensionPref) { |
EXPECT_FALSE(bad_message); |
base::ListValue* bypass_list = new base::ListValue; |
- bypass_list->Append(new base::StringValue("host1")); |
- bypass_list->Append(new base::StringValue("host2")); |
+ bypass_list->AppendString("host1"); |
+ bypass_list->AppendString("host2"); |
base::DictionaryValue* proxy_rules = new base::DictionaryValue; |
proxy_rules->Set(keys::kProxyConfigBypassList, bypass_list); |
proxy_config.Set(keys::kProxyConfigRules, proxy_rules); |
@@ -295,9 +295,9 @@ TEST(ExtensionProxyApiHelpers, GetProxyServer) { |
TEST(ExtensionProxyApiHelpers, JoinUrlList) { |
bool bad_message = false; |
base::ListValue list; |
- list.Append(new base::StringValue("s1")); |
- list.Append(new base::StringValue("s2")); |
- list.Append(new base::StringValue("s3")); |
+ list.AppendString("s1"); |
+ list.AppendString("s2"); |
+ list.AppendString("s3"); |
std::string out; |
std::string error; |
@@ -327,7 +327,7 @@ TEST(ExtensionProxyApiHelpers, CreateProxyRulesDict) { |
expected->Set("fallbackProxy", |
CreateTestProxyServerDict("socks4", "proxy4", 80)); |
base::ListValue* bypass_list = new base::ListValue; |
- bypass_list->Append(new base::StringValue("localhost")); |
+ bypass_list->AppendString("localhost"); |
expected->Set(keys::kProxyConfigBypassList, bypass_list); |
EXPECT_TRUE(base::Value::Equals(expected.get(), extension_pref.get())); |
@@ -355,7 +355,7 @@ TEST(ExtensionProxyApiHelpers, CreateProxyRulesDictMultipleProxies) { |
expected->Set("fallbackProxy", |
CreateTestProxyServerDict("socks4", "proxy4", 80)); |
base::ListValue* bypass_list = new base::ListValue; |
- bypass_list->Append(new base::StringValue("localhost")); |
+ bypass_list->AppendString("localhost"); |
expected->Set(keys::kProxyConfigBypassList, bypass_list); |
EXPECT_TRUE(base::Value::Equals(expected.get(), extension_pref.get())); |
@@ -395,9 +395,9 @@ TEST(ExtensionProxyApiHelpers, CreatePacScriptDictWidthData) { |
TEST(ExtensionProxyApiHelpers, TokenizeToStringList) { |
base::ListValue expected; |
- expected.Append(new base::StringValue("s1")); |
- expected.Append(new base::StringValue("s2")); |
- expected.Append(new base::StringValue("s3")); |
+ expected.AppendString("s1"); |
+ expected.AppendString("s2"); |
+ expected.AppendString("s3"); |
std::unique_ptr<base::ListValue> out(TokenizeToStringList("s1;s2;s3", ";")); |
EXPECT_TRUE(base::Value::Equals(&expected, out.get())); |