chrome/browser/extensions/api/idltest/idltest_api.cc - Issue 2030013003: Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //chrome

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/idltest/idltest_api.cc

Issue 2030013003: Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/extension_action/extension_action_api.cc ('k') | chrome/browser/extensions/api/messaging/native_messaging_policy_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/idltest/idltest_api.cc

diff --git a/chrome/browser/extensions/api/idltest/idltest_api.cc b/chrome/browser/extensions/api/idltest/idltest_api.cc

index bb3685a8bec20467e04bf1894d4e403170da55f6..3f280cf5e194423aa2b0e98e6db7ee7823378b71 100644

--- a/chrome/browser/extensions/api/idltest/idltest_api.cc

+++ b/chrome/browser/extensions/api/idltest/idltest_api.cc

@@ -20,7 +20,7 @@ std::unique_ptr<base::ListValue> CopyBinaryValueToIntegerList(

std::unique_ptr<base::ListValue> output(new base::ListValue());

const char* input_buffer = input->GetBuffer();

for (size_t i = 0; i < input->GetSize(); i++) {

- output->Append(new base::FundamentalValue(input_buffer[i]));

+ output->AppendInteger(input_buffer[i]);

}

return output;

}