Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 2029993002: Add scroll threshold for app list for mouse wheel events. (Closed)

Created:
4 years, 6 months ago by calamity
Modified:
4 years, 6 months ago
Reviewers:
Matt Giuca
CC:
chromium-reviews, tfarina, Matt Giuca, tapted, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@hide_search_bar
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add scroll threshold for app list for mouse wheel events. This CL fixes an issue with touchpad events being read as mousewheel events and causing jank on touchpad scroll in the app list. Instead of figuring out the whole stack and why the wrong event is coming in, just use the scroll threshold everywhere. BUG=594264 Committed: https://crrev.com/4db974d7763416334efdbe4859427475ff5889f9 Cr-Commit-Position: refs/heads/master@{#397642}

Patch Set 1 : #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : TODO - I bless the rains down in Africa #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M ui/app_list/pagination_controller.cc View 1 2 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
calamity
4 years, 6 months ago (2016-06-02 08:40:46 UTC) #2
Matt Giuca
https://codereview.chromium.org/2029993002/diff/40001/ui/app_list/pagination_controller.cc File ui/app_list/pagination_controller.cc (right): https://codereview.chromium.org/2029993002/diff/40001/ui/app_list/pagination_controller.cc#newcode42 ui/app_list/pagination_controller.cc:42: // Do not scroll on very small events. // ...
4 years, 6 months ago (2016-06-02 08:44:18 UTC) #4
Matt Giuca
lgtm with above nit
4 years, 6 months ago (2016-06-02 08:44:41 UTC) #5
calamity
4 years, 6 months ago (2016-06-03 01:25:25 UTC) #6
calamity
https://codereview.chromium.org/2029993002/diff/40001/ui/app_list/pagination_controller.cc File ui/app_list/pagination_controller.cc (right): https://codereview.chromium.org/2029993002/diff/40001/ui/app_list/pagination_controller.cc#newcode42 ui/app_list/pagination_controller.cc:42: // Do not scroll on very small events. On ...
4 years, 6 months ago (2016-06-03 01:25:45 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2029993002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2029993002/60001
4 years, 6 months ago (2016-06-03 01:26:27 UTC) #10
Matt Giuca
I don't get this patch set name.
4 years, 6 months ago (2016-06-03 03:43:53 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:60001)
4 years, 6 months ago (2016-06-03 05:43:13 UTC) #12
commit-bot: I haz the power
4 years, 6 months ago (2016-06-03 05:44:50 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/4db974d7763416334efdbe4859427475ff5889f9
Cr-Commit-Position: refs/heads/master@{#397642}

Powered by Google App Engine
This is Rietveld 408576698