Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Unified Diff: ui/app_list/pagination_controller.cc

Issue 2029993002: Add scroll threshold for app list for mouse wheel events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@hide_search_bar
Patch Set: TODO - I bless the rains down in Africa Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/app_list/pagination_controller.cc
diff --git a/ui/app_list/pagination_controller.cc b/ui/app_list/pagination_controller.cc
index 26494eb24a18901b59922f0ee9bb5efe91cf0dd5..b05357635d266765b7d00f1bd8a3985c40b19af9 100644
--- a/ui/app_list/pagination_controller.cc
+++ b/ui/app_list/pagination_controller.cc
@@ -39,10 +39,10 @@ bool PaginationController::OnScroll(const gfx::Vector2d& offset,
offset_magnitude = offset.y();
}
- // Do not scroll on very small touchpad events. Mouse wheel events should
- // scroll, no matter how small the value change.
- if (type == SCROLL_MOUSE_WHEEL ||
- abs(offset_magnitude) > kMinScrollToSwitchPage) {
+ // Do not scroll on very small events.
+ // TODO(calamity): This should only apply on touchpad scroll but touchpad
+ // events are coming in as mousewheel events. See https://crbug.com/594264.
+ if (abs(offset_magnitude) > kMinScrollToSwitchPage) {
if (!pagination_model_->has_transition()) {
pagination_model_->SelectPageRelative(offset_magnitude > 0 ? -1 : 1,
true);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698