chrome/browser/lifetime/application_lifetime_win.cc - Issue 202993002: Fix "unreachable code" warnings (MSVC warning 4702) in chrome/browser/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/lifetime/application_lifetime_win.cc

Issue 202993002: Fix "unreachable code" warnings (MSVC warning 4702) in chrome/browser/. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/media_galleries_private/gallery_watch_state_tracker.cc ('k') | chrome/browser/media/chrome_webrtc_apprtc_browsertest.cc » ('j') | chrome/browser/renderer_context_menu/context_menu_content_type.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/lifetime/application_lifetime_win.cc

===================================================================

--- chrome/browser/lifetime/application_lifetime_win.cc (revision 256983)

+++ chrome/browser/lifetime/application_lifetime_win.cc (working copy)

@@ -46,9 +46,8 @@

#if defined(USE_AURA)

// This function should be called only from non aura code path.

// In aura/ash windows world browser process is always non metro.

- CHECK(false);

- return;

-#endif

+ NOTREACHED();

Peter Kasting 2014/03/18 02:43:58 (I verified with shrikant that changing this CHECK

+#else

// The kRestartSwitchMode preference does not exists for Windows 7 and older

// operating systems so there is no need for OS version check.

PrefService* prefs = g_browser_process->local_state();

@@ -60,6 +59,7 @@

upgrade_util::kRelaunchModeMetro);

}

AttemptRestart();

+#endif

}

#if defined(USE_AURA)