third_party/WebKit/Source/core/dom/custom/CustomElementsRegistry.h - Issue 2029923003: Recursively defining custom elements should not lead to redefinition

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/custom/CustomElementsRegistry.h

Issue 2029923003: Recursively defining custom elements should not lead to redefinition (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinitionBuilder.cpp ('K') | « third_party/WebKit/Source/core/dom/custom/CustomElementDefinitionBuilder.h ('k') | third_party/WebKit/Source/core/dom/custom/CustomElementsRegistry.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/custom/CustomElementsRegistry.h

diff --git a/third_party/WebKit/Source/core/dom/custom/CustomElementsRegistry.h b/third_party/WebKit/Source/core/dom/custom/CustomElementsRegistry.h

index 292f86bed06af745541b05496ea41a545bdde531..534215698f27f8ac49e92af95661a0629bc46ca3 100644

--- a/third_party/WebKit/Source/core/dom/custom/CustomElementsRegistry.h

+++ b/third_party/WebKit/Source/core/dom/custom/CustomElementsRegistry.h

@@ -8,6 +8,7 @@

#include "bindings/core/v8/ScriptWrappable.h"

#include "core/CoreExport.h"

#include "platform/heap/Handle.h"

+#include "wtf/HashSet.h"

#include "wtf/Noncopyable.h"

#include "wtf/text/AtomicString.h"

#include "wtf/text/AtomicStringHash.h"

@@ -57,6 +58,9 @@ private:

CustomElementsRegistry(const V0CustomElementRegistrationContext*);

bool v0NameIsDefined(const AtomicString&) const;

+ class NameIsBeingDefined;

+ HashSet<AtomicString> m_namesBeingDefined;

using DefinitionMap =

HeapHashMap<AtomicString, Member<CustomElementDefinition>>;

DefinitionMap m_definitions;