third_party/WebKit/Source/core/dom/custom/CustomElementDefinitionBuilder.h - Issue 2029923003: Recursively defining custom elements should not lead to redefinition

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/custom/CustomElementDefinitionBuilder.h

Issue 2029923003: Recursively defining custom elements should not lead to redefinition (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinitionBuilder.cpp ('K') | « third_party/WebKit/Source/bindings/core/v8/V8PrivateProperty.h ('k') | third_party/WebKit/Source/core/dom/custom/CustomElementsRegistry.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/custom/CustomElementDefinitionBuilder.h

diff --git a/third_party/WebKit/Source/core/dom/custom/CustomElementDefinitionBuilder.h b/third_party/WebKit/Source/core/dom/custom/CustomElementDefinitionBuilder.h

index 7c8dcd9cd0c57b7c5c568486968b4e56e6443333..d13bdcb9ff72aae41bd0d8f0085358cfa023665b 100644

--- a/third_party/WebKit/Source/core/dom/custom/CustomElementDefinitionBuilder.h

+++ b/third_party/WebKit/Source/core/dom/custom/CustomElementDefinitionBuilder.h

@@ -25,7 +25,8 @@ class CORE_EXPORT CustomElementDefinitionBuilder {

STACK_ALLOCATED();

WTF_MAKE_NONCOPYABLE(CustomElementDefinitionBuilder);

public:

- CustomElementDefinitionBuilder() { }

+ CustomElementDefinitionBuilder() = default;

+ virtual ~CustomElementDefinitionBuilder() = default;

// This API necessarily sounds JavaScript specific; this implements

// some steps of the CustomElementsRegistry.define process, which