Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2467)

Unified Diff: chrome/browser/download/download_browsertest.cc

Issue 2029903002: Add token field to ClientSafeBrowsingReportReqeust (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: tweak comments Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/download/download_browsertest.cc
diff --git a/chrome/browser/download/download_browsertest.cc b/chrome/browser/download/download_browsertest.cc
index 343f8d656bc6d422f96314c1c4341fcd02d60ed4..93d901bd0bebf61dea99fbdbd29ef5018409b02e 100644
--- a/chrome/browser/download/download_browsertest.cc
+++ b/chrome/browser/download/download_browsertest.cc
@@ -127,6 +127,7 @@ using net::URLRequestMockHTTPJob;
namespace {
const char kDownloadTest1Path[] = "download-test1.lib";
+const char kDownloadResponseToken[] = "download_token";
class CreatedObserver : public content::DownloadManager::Observer {
public:
@@ -1083,9 +1084,10 @@ class FakeDownloadProtectionService
: safe_browsing::DownloadProtectionService(nullptr) {}
void CheckClientDownload(DownloadItem* download_item,
- const CheckDownloadCallback& callback) override {
+ const CheckDownloadContentCallback& callback) override {
callback.Run(
- safe_browsing::DownloadProtectionService::UNCOMMON);
+ safe_browsing::DownloadProtectionService::UNCOMMON,
+ kDownloadResponseToken);
}
};
@@ -3387,6 +3389,7 @@ IN_PROC_BROWSER_TEST_F(
actual_report.download_verdict());
EXPECT_EQ(download_url.spec(), actual_report.url());
EXPECT_TRUE(actual_report.did_proceed());
+ EXPECT_EQ(kDownloadResponseToken, actual_report.token());
download->Cancel(true);
}

Powered by Google App Engine
This is Rietveld 408576698