Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1060)

Unified Diff: chrome/browser/download/chrome_download_manager_delegate.cc

Issue 2029903002: Add token field to ClientSafeBrowsingReportReqeust (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: tweak comments Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/download/chrome_download_manager_delegate.cc
diff --git a/chrome/browser/download/chrome_download_manager_delegate.cc b/chrome/browser/download/chrome_download_manager_delegate.cc
index 4819efc41ff4c4aad3f8e04a819c1181bbabcbcb..fa5ba726d5ecf14392d668e4cb12b3d2b11fc50d 100644
--- a/chrome/browser/download/chrome_download_manager_delegate.cc
+++ b/chrome/browser/download/chrome_download_manager_delegate.cc
@@ -333,7 +333,8 @@ bool ChromeDownloadManagerDelegate::IsDownloadReadyForCompletion(
DVLOG(2) << __FUNCTION__
<< "() SB service disabled. Marking download as DANGEROUS FILE";
item->OnContentCheckCompleted(
- content::DOWNLOAD_DANGER_TYPE_DANGEROUS_FILE);
+ content::DOWNLOAD_DANGER_TYPE_DANGEROUS_FILE,
+ base::EmptyString());
asanka 2016/06/06 20:39:27 base::EmptyString() shouldn't be used in function
Jialiu Lin 2016/06/07 20:34:01 Fixed.Thanks!
content::BrowserThread::PostTask(content::BrowserThread::UI, FROM_HERE,
internal_complete_callback);
return false;
@@ -651,7 +652,8 @@ void ChromeDownloadManagerDelegate::GetFileMimeType(
#if defined(FULL_SAFE_BROWSING)
void ChromeDownloadManagerDelegate::CheckClientDownloadDone(
uint32_t download_id,
- DownloadProtectionService::DownloadCheckResult result) {
+ DownloadProtectionService::DownloadCheckResult result,
+ const std::string& token) {
DownloadItem* item = download_manager_->GetDownload(download_id);
if (!item || (item->GetState() != DownloadItem::IN_PROGRESS))
return;
@@ -697,7 +699,7 @@ void ChromeDownloadManagerDelegate::CheckClientDownloadDone(
content::DOWNLOAD_DANGER_TYPE_MAYBE_DANGEROUS_CONTENT);
if (danger_type != content::DOWNLOAD_DANGER_TYPE_NOT_DANGEROUS)
- item->OnContentCheckCompleted(danger_type);
+ item->OnContentCheckCompleted(danger_type, token);
}
SafeBrowsingState* state = static_cast<SafeBrowsingState*>(

Powered by Google App Engine
This is Rietveld 408576698