Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2655)

Unified Diff: chrome/browser/download/chrome_download_manager_delegate_unittest.cc

Issue 2029903002: Add token field to ClientSafeBrowsingReportReqeust (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: tweak comments Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/download/chrome_download_manager_delegate_unittest.cc
diff --git a/chrome/browser/download/chrome_download_manager_delegate_unittest.cc b/chrome/browser/download/chrome_download_manager_delegate_unittest.cc
index da500dcf04cf355b245c92357123214a96b7a285..e7dea993fff1c89db4b39d36c2b0844890ef2ff8 100644
--- a/chrome/browser/download/chrome_download_manager_delegate_unittest.cc
+++ b/chrome/browser/download/chrome_download_manager_delegate_unittest.cc
@@ -12,6 +12,7 @@
#include "base/message_loop/message_loop.h"
#include "base/run_loop.h"
#include "base/single_thread_task_runner.h"
+#include "base/strings/string_util.h"
#include "base/threading/thread_task_runner_handle.h"
#include "chrome/browser/download/chrome_download_manager_delegate.h"
#include "chrome/browser/download/download_item_model.h"
@@ -493,9 +494,10 @@ class TestDownloadProtectionService
public:
TestDownloadProtectionService() : DownloadProtectionService(nullptr) {}
- void CheckClientDownload(DownloadItem* download_item,
- const CheckDownloadCallback& callback) override {
- callback.Run(MockCheckClientDownload());
+ void CheckClientDownload(
+ DownloadItem* download_item,
+ const CheckDownloadContentCallback& callback) override {
+ callback.Run(MockCheckClientDownload(), base::EmptyString());
}
MOCK_METHOD0(MockCheckClientDownload,
safe_browsing::DownloadProtectionService::DownloadCheckResult());
@@ -661,9 +663,10 @@ TEST_P(ChromeDownloadManagerDelegateTestWithSafeBrowsing, CheckClientDownload) {
if (kParameters.expected_danger_type !=
content::DOWNLOAD_DANGER_TYPE_NOT_DANGEROUS) {
EXPECT_CALL(*download_item,
- OnContentCheckCompleted(kParameters.expected_danger_type));
+ OnContentCheckCompleted(kParameters.expected_danger_type,
+ base::EmptyString()));
} else {
- EXPECT_CALL(*download_item, OnContentCheckCompleted(_)).Times(0);
+ EXPECT_CALL(*download_item, OnContentCheckCompleted(_, _)).Times(0);
}
base::RunLoop run_loop;

Powered by Google App Engine
This is Rietveld 408576698