Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2690)

Unified Diff: cc/quads/draw_quad_unittest.cc

Issue 2029813002: cc::SharedQuadState: drop CopyFrom and add copy constructor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Use = default in cc Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/quads/draw_quad_perftest.cc ('k') | cc/quads/render_pass.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/quads/draw_quad_unittest.cc
diff --git a/cc/quads/draw_quad_unittest.cc b/cc/quads/draw_quad_unittest.cc
index 4172d940873536c62139a0c2500ed36bb0b4d0a4..8045d8c00126e6df8ea860f0f342805c068c7dd6 100644
--- a/cc/quads/draw_quad_unittest.cc
+++ b/cc/quads/draw_quad_unittest.cc
@@ -46,8 +46,7 @@ TEST(DrawQuadTest, CopySharedQuadState) {
state->SetAll(quad_transform, layer_bounds, visible_layer_rect, clip_rect,
is_clipped, opacity, blend_mode, sorting_context_id);
- std::unique_ptr<SharedQuadState> copy(new SharedQuadState);
- copy->CopyFrom(state.get());
+ std::unique_ptr<SharedQuadState> copy(new SharedQuadState(*state));
EXPECT_EQ(quad_transform, copy->quad_to_target_transform);
EXPECT_EQ(visible_layer_rect, copy->visible_quad_layer_rect);
EXPECT_EQ(opacity, copy->opacity);
@@ -88,7 +87,7 @@ void CompareDrawQuad(DrawQuad* quad,
SharedQuadState* shared_state(CreateSharedQuadState(render_pass.get())); \
SharedQuadState* copy_shared_state = \
render_pass->CreateAndAppendSharedQuadState(); \
- copy_shared_state->CopyFrom(shared_state);
+ *copy_shared_state = *shared_state;
#define QUAD_DATA \
gfx::Rect quad_rect(30, 40, 50, 60); \
« no previous file with comments | « cc/quads/draw_quad_perftest.cc ('k') | cc/quads/render_pass.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698