Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Unified Diff: build/common.gypi

Issue 2029633002: mac: Use -fstack-protector-strong instead of -fstack-protector-all. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/config/compiler/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index 1d69c51821c0423ade5b7ced71ab4619916c1d6a..c81899ec9b6cc585bd71beca03f084cee76ce427 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -3375,7 +3375,7 @@
['release_valgrind_build==0', {
'xcode_settings': {
'OTHER_CFLAGS': [
- '-fstack-protector-all', # Implies -fstack-protector
+ '-fstack-protector-strong', # Implies -fstack-protector
],
},
}],
@@ -3593,7 +3593,7 @@
# and we want to avoid overriding this, so stack-protector is only
# enabled when not building on Chrome OS.
# TODO(phajdan.jr): Use -fstack-protector-strong when our gcc
- # supports it.
+ # supports it. See also https://crbug.com/533294
'target_defaults': {
'cflags': [
'-fstack-protector',
« no previous file with comments | « no previous file | build/config/compiler/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698