Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Side by Side Diff: build/common.gypi

Issue 2029633002: mac: Use -fstack-protector-strong instead of -fstack-protector-all. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | build/config/compiler/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # IMPORTANT: 5 # IMPORTANT:
6 # Please don't directly include this file if you are building via gyp_chromium, 6 # Please don't directly include this file if you are building via gyp_chromium,
7 # since gyp_chromium is automatically forcing its inclusion. 7 # since gyp_chromium is automatically forcing its inclusion.
8 { 8 {
9 # Variables expected to be overriden on the GYP command line (-D) or by 9 # Variables expected to be overriden on the GYP command line (-D) or by
10 # ~/.gyp/include.gypi. 10 # ~/.gyp/include.gypi.
(...skipping 3357 matching lines...) Expand 10 before | Expand all | Expand 10 after
3368 }], 3368 }],
3369 ['OS=="linux" and target_arch!="ia32" and disable_glibcxx_debug==0', { 3369 ['OS=="linux" and target_arch!="ia32" and disable_glibcxx_debug==0', {
3370 # Enable libstdc++ debugging facilities to help catch problems 3370 # Enable libstdc++ debugging facilities to help catch problems
3371 # early, see http://crbug.com/65151 . 3371 # early, see http://crbug.com/65151 .
3372 # TODO(phajdan.jr): Should we enable this for all of POSIX? 3372 # TODO(phajdan.jr): Should we enable this for all of POSIX?
3373 'defines': ['_GLIBCXX_DEBUG=1',], 3373 'defines': ['_GLIBCXX_DEBUG=1',],
3374 }], 3374 }],
3375 ['release_valgrind_build==0', { 3375 ['release_valgrind_build==0', {
3376 'xcode_settings': { 3376 'xcode_settings': {
3377 'OTHER_CFLAGS': [ 3377 'OTHER_CFLAGS': [
3378 '-fstack-protector-all', # Implies -fstack-protector 3378 '-fstack-protector-strong', # Implies -fstack-protector
3379 ], 3379 ],
3380 }, 3380 },
3381 }], 3381 }],
3382 ], 3382 ],
3383 }, 3383 },
3384 'Release_Base': { 3384 'Release_Base': {
3385 'abstract': 1, 3385 'abstract': 1,
3386 'defines': [ 3386 'defines': [
3387 'NDEBUG', 3387 'NDEBUG',
3388 ], 3388 ],
(...skipping 197 matching lines...) Expand 10 before | Expand all | Expand 10 after
3586 'ldflags': [ 3586 'ldflags': [
3587 '-Wl,-z,defs', 3587 '-Wl,-z,defs',
3588 ], 3588 ],
3589 }, 3589 },
3590 }], 3590 }],
3591 ['os_posix==1 and chromeos==0', { 3591 ['os_posix==1 and chromeos==0', {
3592 # Chrome OS enables -fstack-protector-strong via its build wrapper, 3592 # Chrome OS enables -fstack-protector-strong via its build wrapper,
3593 # and we want to avoid overriding this, so stack-protector is only 3593 # and we want to avoid overriding this, so stack-protector is only
3594 # enabled when not building on Chrome OS. 3594 # enabled when not building on Chrome OS.
3595 # TODO(phajdan.jr): Use -fstack-protector-strong when our gcc 3595 # TODO(phajdan.jr): Use -fstack-protector-strong when our gcc
3596 # supports it. 3596 # supports it. See also https://crbug.com/533294
3597 'target_defaults': { 3597 'target_defaults': {
3598 'cflags': [ 3598 'cflags': [
3599 '-fstack-protector', 3599 '-fstack-protector',
3600 '--param=ssp-buffer-size=4', 3600 '--param=ssp-buffer-size=4',
3601 ], 3601 ],
3602 }, 3602 },
3603 }], 3603 }],
3604 ['os_posix==1 and OS=="linux"', { 3604 ['os_posix==1 and OS=="linux"', {
3605 'defines': [ 3605 'defines': [
3606 '_LARGEFILE_SOURCE', 3606 '_LARGEFILE_SOURCE',
(...skipping 2719 matching lines...) Expand 10 before | Expand all | Expand 10 after
6326 # settings in target dicts. SYMROOT is a special case, because many other 6326 # settings in target dicts. SYMROOT is a special case, because many other
6327 # Xcode variables depend on it, including variables such as 6327 # Xcode variables depend on it, including variables such as
6328 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something 6328 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something
6329 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the 6329 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
6330 # files to appear (when present) in the UI as actual files and not red 6330 # files to appear (when present) in the UI as actual files and not red
6331 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR, 6331 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
6332 # and therefore SYMROOT, needs to be set at the project level. 6332 # and therefore SYMROOT, needs to be set at the project level.
6333 'SYMROOT': '<(DEPTH)/xcodebuild', 6333 'SYMROOT': '<(DEPTH)/xcodebuild',
6334 }, 6334 },
6335 } 6335 }
OLDNEW
« no previous file with comments | « no previous file | build/config/compiler/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698