Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Unified Diff: tools/perf/measurements/page_cycler_unittest.py

Issue 2029483002: [PCv1] Avoid using dot in metrics name (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix typo Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/perf/measurements/page_cycler.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/measurements/page_cycler_unittest.py
diff --git a/tools/perf/measurements/page_cycler_unittest.py b/tools/perf/measurements/page_cycler_unittest.py
index 5fa0deed3ec33d98f65ed13f29f7c1f63e164f57..ecc0c2459331a5947efb561b1a9b44f441a1425b 100644
--- a/tools/perf/measurements/page_cycler_unittest.py
+++ b/tools/perf/measurements/page_cycler_unittest.py
@@ -210,7 +210,7 @@ class PageCyclerUnitTest(unittest.TestCase):
self.assertEqual(values[0].page, page)
chart_name = 'cold_times' if i == 0 or i > 2 else 'warm_times'
- self.assertEqual(values[0].name, '%s.page_load_time' % chart_name)
+ self.assertEqual(values[0].name, '%s-page_load_time' % chart_name)
self.assertEqual(values[0].units, 'ms')
cycler.DidNavigateToPage(page, tab)
@@ -233,7 +233,7 @@ class PageCyclerUnitTest(unittest.TestCase):
self.assertEqual(values[0].page, page)
chart_name = 'cold_times' if i == 0 or i > 1 else 'warm_times'
- self.assertEqual(values[0].name, '%s.page_load_time' % chart_name)
+ self.assertEqual(values[0].name, '%s-page_load_time' % chart_name)
self.assertEqual(values[0].units, 'ms')
cycler.DidNavigateToPage(page, tab)
@@ -256,20 +256,20 @@ class PageCyclerUnitTest(unittest.TestCase):
# On Mac, there is an additional measurement: the number of keychain
# accesses.
- value_count = 4
+ value_count = 6
if sys.platform == 'darwin':
value_count += 1
self.assertEqual(value_count, len(values))
self.assertEqual(values[0].page, page)
chart_name = 'cold_times' if i == 0 else 'warm_times'
- self.assertEqual(values[0].name, '%s.page_load_time' % chart_name)
+ self.assertEqual(values[0].name, '%s-page_load_time' % chart_name)
self.assertEqual(values[0].units, 'ms')
- self.assertEqual(values[1].name, '%s.time_to_onload' % chart_name)
+ self.assertEqual(values[1].name, '%s-time_to_onload' % chart_name)
self.assertEqual(values[1].units, 'ms')
expected_values = ['gpu', 'browser']
- for value, expected in zip(values[2:len(expected_values) + 1],
+ for value, expected in zip(values[4:len(expected_values) + 1],
expected_values):
self.assertEqual(value.page, page)
self.assertEqual(value.name,
« no previous file with comments | « tools/perf/measurements/page_cycler.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698