[PCv1] Avoid using dot in metrics name

tools/perf/measurements/page_cycler_unittest.py

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import sys
 import unittest
 
 from telemetry.internal.browser import browser_options
 from telemetry.internal.results import page_test_results
 from telemetry.internal import story_runner
@@ skipping 192 matching lines @@
                        'Iteration %d tab.clear_cache_calls %d' %
                        (i, tab.clear_cache_calls))
       cycler.ValidateAndMeasurePage(page, tab, results)
       results.DidRunPage(page)
 
       values = results.all_page_specific_values
       self.assertGreater(len(values), 2)
 
       self.assertEqual(values[0].page, page)
       chart_name = 'cold_times' if i == 0 or i > 2 else 'warm_times'
-      self.assertEqual(values[0].name, '%s.page_load_time' % chart_name)
+      self.assertEqual(values[0].name, '%s-page_load_time' % chart_name)
       self.assertEqual(values[0].units, 'ms')
 
       cycler.DidNavigateToPage(page, tab)
 
   def testColdWarm(self):
     cycler = self.SetUpCycler(pageset_repeat=3, setup_memory_module=True)
     pages = [FakePage('http://fakepage1.com'), FakePage('http://fakepage2.com')]
     tab = FakeTab()
     for i in range(3):
       for page in pages:
         results = page_test_results.PageTestResults()
         results.WillRunPage(page)
         cycler.WillNavigateToPage(page, tab)
         cycler.ValidateAndMeasurePage(page, tab, results)
         results.DidRunPage(page)
 
         values = results.all_page_specific_values
         self.assertGreater(len(values), 2)
 
         self.assertEqual(values[0].page, page)
 
         chart_name = 'cold_times' if i == 0 or i > 1 else 'warm_times'
-        self.assertEqual(values[0].name, '%s.page_load_time' % chart_name)
+        self.assertEqual(values[0].name, '%s-page_load_time' % chart_name)
         self.assertEqual(values[0].units, 'ms')
 
         cycler.DidNavigateToPage(page, tab)
 
   def testResults(self):
     cycler = self.SetUpCycler(setup_memory_module=True)
 
     pages = [FakePage('http://fakepage1.com'), FakePage('http://fakepage2.com')]
     tab = FakeTab()
 
     for i in range(2):
       for page in pages:
         results = page_test_results.PageTestResults()
         results.WillRunPage(page)
         cycler.WillNavigateToPage(page, tab)
         cycler.ValidateAndMeasurePage(page, tab, results)
         results.DidRunPage(page)
 
         values = results.all_page_specific_values
 
         # On Mac, there is an additional measurement: the number of keychain
         # accesses.
-        value_count = 4
+        value_count = 6
         if sys.platform == 'darwin':
           value_count += 1
         self.assertEqual(value_count, len(values))
 
         self.assertEqual(values[0].page, page)
         chart_name = 'cold_times' if i == 0 else 'warm_times'
-        self.assertEqual(values[0].name, '%s.page_load_time' % chart_name)
+        self.assertEqual(values[0].name, '%s-page_load_time' % chart_name)
         self.assertEqual(values[0].units, 'ms')
-        self.assertEqual(values[1].name, '%s.time_to_onload' % chart_name)
+        self.assertEqual(values[1].name, '%s-time_to_onload' % chart_name)
         self.assertEqual(values[1].units, 'ms')
 
         expected_values = ['gpu', 'browser']
-        for value, expected in zip(values[2:len(expected_values) + 1],
+        for value, expected in zip(values[4:len(expected_values) + 1],
                                    expected_values):
           self.assertEqual(value.page, page)
           self.assertEqual(value.name,
                            'cpu_utilization.cpu_utilization_%s' % expected)
           self.assertEqual(value.units, '%')
 
         cycler.DidNavigateToPage(page, tab)
 
   def testLegacyPagesAvoidCrossRenderNavigation(self):
     # For legacy page cyclers with file URLs, verify that WillNavigateToPage
     # does an initial navigate to avoid paying for a cross-renderer navigation.
     cycler = self.SetUpCycler(setup_memory_module=True)
     pages = [FakePage('file://fakepage1.com'), FakePage('file://fakepage2.com')]
     tab = FakeTab()
 
     self.assertEqual([], tab.navigated_urls)
     for page in pages * 2:
       cycler.WillNavigateToPage(page, tab)
       self.assertEqual(
           ['http://fakeserver:99999/nonexistent.html'], tab.navigated_urls)