third_party/WebKit/Source/web/WebViewImpl.h - Issue 2029423003: OOPIF IME: Renderer Side Changes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebViewImpl.h

Issue 2029423003: OOPIF IME: Renderer Side Changes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/WebViewImpl.h

diff --git a/third_party/WebKit/Source/web/WebViewImpl.h b/third_party/WebKit/Source/web/WebViewImpl.h

index 70905512f151dc17ad4376ec6ec27677327c4487..881bbc58a21b0582f4d72b973c869150c080e2cb 100644

--- a/third_party/WebKit/Source/web/WebViewImpl.h

+++ b/third_party/WebKit/Source/web/WebViewImpl.h

@@ -157,6 +157,8 @@ public:

void didNotAcquirePointerLock() override;

void didLosePointerLock() override;

void didChangeWindowResizerRect() override;

+ bool getCompositionCharacterBounds(WebVector<WebRect>& bounds) override;

lfg 2016/07/05 18:30:46 Can you move those functions to the private sectio

EhsanK 2016/07/07 14:40:47 Given our offline discussion this needs a change h

+ void applyReplacementRange(int start, int length) override;

// WebView methods:

virtual bool isWebView() const { return true; }