OOPIF IME: Renderer Side Changes

third_party/WebKit/Source/web/WebViewImpl.h

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 139 matching lines @@
     bool selectionTextDirection(WebTextDirection& start, WebTextDirection& end) const override;
     bool isSelectionAnchorFirst() const override;
     bool caretOrSelectionRange(size_t* location, size_t* length) override;
     void setTextDirection(WebTextDirection) override;
     bool isAcceleratedCompositingActive() const override;
     void willCloseLayerTreeView() override;
     void didAcquirePointerLock() override;
     void didNotAcquirePointerLock() override;
     void didLosePointerLock() override;
     void didChangeWindowResizerRect() override;
+    bool getCompositionCharacterBounds(WebVector<WebRect>& bounds) override;

[lfg, 2016/07/05 18:30:46]

Can you move those functions to the private section, and make sure that they are
called from WebFrameWidget? (for the main frame, it should go through
WebViewFrameWidget).

[EhsanK, 2016/07/07 14:40:47]

Given our offline discussion this needs a change here:
https://cs.chromium.org/chromium/src/content/renderer/render_widget.cc?rcl=14...
to create a WebViewFrameWidget instead of a WebVewImpl. So leave it for a later
time I guess.

+    void applyReplacementRange(int start, int length) override;
 
     // WebView methods:
     virtual bool isWebView() const { return true; }
     void setMainFrame(WebFrame*) override;
     void setCredentialManagerClient(WebCredentialManagerClient*) override;
     void setPrerendererClient(WebPrerendererClient*) override;
     void setSpellCheckClient(WebSpellCheckClient*) override;
     WebSettings* settings() override;
     WebString pageEncoding() const override;
     void setPageEncoding(const WebString&) override;
@@ skipping 589 matching lines @@
     double m_lastFrameTimeMonotonic;
 };
 
 // We have no ways to check if the specified WebView is an instance of
 // WebViewImpl because WebViewImpl is the only implementation of WebView.
 DEFINE_TYPE_CASTS(WebViewImpl, WebView, webView, true, true);
 
 } // namespace blink
 
 #endif