[builtins] Migrate Math.log to TurboFan.

[builtins] Migrate Math.log to TurboFan.

Introduce a dedicated Float64Log machine operator, that is either
implemented by a direct C call or by platform specific code, i.e.
using the FPU on x64 and ia32.

This operator is used to implement Math.log as a proper TurboFan
builtin on top of the CodeStubAssembler.

Also introduce a NumberLog simplified operator on top of Float64Log
and use that for the fast inline path of Math.log inside TurboFan
optimized code.

BUG=v8:5065
Committed: https://crrev.com/f2da19fe393124c517f9949183e988e669e4f628
Cr-Commit-Position: refs/heads/master@{#36703}

[Benedikt Meurer, 2016-06-03 07:18:23]

Description was changed from

==========
[builtins] Migrate Math.log to TurboFan.

Introduce a dedicated Float64Log machine operator, that is either
implemented by a direct C call or by platform specific code, i.e.
using the FPU on x64 and ia32.

This operator is used to implement Math.log as a proper TurboFan
builtin on top of the CodeStubAssembler.

Also introduce a NumberLog simplified operator on top of Float64Log
and use that for the fast inline path of Math.log inside TurboFan
optimized code.

BUG=internal b/29105497, v8:5065
==========

to

==========
[builtins] Migrate Math.log to TurboFan.

Introduce a dedicated Float64Log machine operator, that is either
implemented by a direct C call or by platform specific code, i.e.
using the FPU on x64 and ia32.

This operator is used to implement Math.log as a proper TurboFan
builtin on top of the CodeStubAssembler.

Also introduce a NumberLog simplified operator on top of Float64Log
and use that for the fast inline path of Math.log inside TurboFan
optimized code.

BUG=v8:5065,internal b/29105497
==========

[Benedikt Meurer, 2016-06-03 07:18:39]

Description was changed from

==========
[builtins] Migrate Math.log to TurboFan.

Introduce a dedicated Float64Log machine operator, that is either
implemented by a direct C call or by platform specific code, i.e.
using the FPU on x64 and ia32.

This operator is used to implement Math.log as a proper TurboFan
builtin on top of the CodeStubAssembler.

Also introduce a NumberLog simplified operator on top of Float64Log
and use that for the fast inline path of Math.log inside TurboFan
optimized code.

BUG=v8:5065,internal b/29105497
==========

to

==========
[builtins] Migrate Math.log to TurboFan.

Introduce a dedicated Float64Log machine operator, that is either
implemented by a direct C call or by platform specific code, i.e.
using the FPU on x64 and ia32.

This operator is used to implement Math.log as a proper TurboFan
builtin on top of the CodeStubAssembler.

Also introduce a NumberLog simplified operator on top of Float64Log
and use that for the fast inline path of Math.log inside TurboFan
optimized code.

BUG=v8:5065, internal b/29105497
==========

[Benedikt Meurer, 2016-06-03 07:18:54]

Description was changed from

==========
[builtins] Migrate Math.log to TurboFan.

Introduce a dedicated Float64Log machine operator, that is either
implemented by a direct C call or by platform specific code, i.e.
using the FPU on x64 and ia32.

This operator is used to implement Math.log as a proper TurboFan
builtin on top of the CodeStubAssembler.

Also introduce a NumberLog simplified operator on top of Float64Log
and use that for the fast inline path of Math.log inside TurboFan
optimized code.

BUG=v8:5065, internal b/29105497
==========

to

==========
[builtins] Migrate Math.log to TurboFan.

Introduce a dedicated Float64Log machine operator, that is either
implemented by a direct C call or by platform specific code, i.e.
using the FPU on x64 and ia32.

This operator is used to implement Math.log as a proper TurboFan
builtin on top of the CodeStubAssembler.

Also introduce a NumberLog simplified operator on top of Float64Log
and use that for the fast inline path of Math.log inside TurboFan
optimized code.

BUG=v8:5065, b/29105497
==========

[Benedikt Meurer, 2016-06-03 07:19:05]

Description was changed from

==========
[builtins] Migrate Math.log to TurboFan.

Introduce a dedicated Float64Log machine operator, that is either
implemented by a direct C call or by platform specific code, i.e.
using the FPU on x64 and ia32.

This operator is used to implement Math.log as a proper TurboFan
builtin on top of the CodeStubAssembler.

Also introduce a NumberLog simplified operator on top of Float64Log
and use that for the fast inline path of Math.log inside TurboFan
optimized code.

BUG=v8:5065, b/29105497
==========

to

==========
[builtins] Migrate Math.log to TurboFan.

Introduce a dedicated Float64Log machine operator, that is either
implemented by a direct C call or by platform specific code, i.e.
using the FPU on x64 and ia32.

This operator is used to implement Math.log as a proper TurboFan
builtin on top of the CodeStubAssembler.

Also introduce a NumberLog simplified operator on top of Float64Log
and use that for the fast inline path of Math.log inside TurboFan
optimized code.

BUG=v8:5065
==========

[Benedikt Meurer, 2016-06-03 07:48:07]

bmeurer@chromium.org changed reviewers:
+ yangguo@chromium.org

[Benedikt Meurer, 2016-06-03 07:48:08]

Hey Yang,

Here's the starter, Math.log. :-)
Please take a look.

Thanks,
Benedikt

[ahaas, 2016-06-03 09:32:48]

ahaas@chromium.org changed reviewers:
+ ahaas@chromium.org

[ahaas, 2016-06-03 09:32:49]

https://codereview.chromium.org/2029413005/diff/40001/test/cctest/compiler/te...
File test/cctest/compiler/test-run-machops.cc (right):

https://codereview.chromium.org/2029413005/diff/40001/test/cctest/compiler/te...
test/cctest/compiler/test-run-machops.cc:5501:
CHECK(std::isnan(m.Call(std::numeric_limits<double>::quiet_NaN())));
Aren't these checks included in the FOR_FLOAT64_INPUTS anyways?

[Benedikt Meurer, 2016-06-03 09:40:29]

https://codereview.chromium.org/2029413005/diff/40001/test/cctest/compiler/te...
File test/cctest/compiler/test-run-machops.cc (right):

https://codereview.chromium.org/2029413005/diff/40001/test/cctest/compiler/te...
test/cctest/compiler/test-run-machops.cc:5501:
CHECK(std::isnan(m.Call(std::numeric_limits<double>::quiet_NaN())));
Yes, but I want to make them explicit. These are the cases that explicitly
listed in the spec.

[Yang, 2016-06-03 09:41:43]

lgtm

https://codereview.chromium.org/2029413005/diff/40001/src/compiler/arm64/code...
File src/compiler/arm64/code-generator-arm64.cc (right):

https://codereview.chromium.org/2029413005/diff/40001/src/compiler/arm64/code...
src/compiler/arm64/code-generator-arm64.cc:1246: // TODO(dcarney): implement
directly. See note in lithium-codegen-arm64.cc
TODO(dcarney)....?

https://codereview.chromium.org/2029413005/diff/40001/test/mjsunit/regress/re...
File test/mjsunit/regress/regress-1246.js (left):

https://codereview.chromium.org/2029413005/diff/40001/test/mjsunit/regress/re...
test/mjsunit/regress/regress-1246.js:34: var nonSmi16 = Math.log(Math.exp(16));
Is there a way to create heap numbers so that we can keep this test?

[Benedikt Meurer, 2016-06-03 09:45:03]

https://codereview.chromium.org/2029413005/diff/40001/src/compiler/arm64/code...
File src/compiler/arm64/code-generator-arm64.cc (right):

https://codereview.chromium.org/2029413005/diff/40001/src/compiler/arm64/code...
src/compiler/arm64/code-generator-arm64.cc:1246: // TODO(dcarney): implement
directly. See note in lithium-codegen-arm64.cc
Copy and paste :-)

https://codereview.chromium.org/2029413005/diff/40001/test/mjsunit/regress/re...
File test/mjsunit/regress/regress-1246.js (left):

https://codereview.chromium.org/2029413005/diff/40001/test/mjsunit/regress/re...
test/mjsunit/regress/regress-1246.js:34: var nonSmi16 = Math.log(Math.exp(16));
As discussed offline, this is not relevant anymore.

[Benedikt Meurer, 2016-06-03 09:45:16]

The CQ bit was checked by bmeurer@chromium.org

[commit-bot: I haz the power, 2016-06-03 09:45:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2029413005/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2029413005/40001

[commit-bot: I haz the power, 2016-06-03 09:47:31]

Description was changed from

==========
[builtins] Migrate Math.log to TurboFan.

Introduce a dedicated Float64Log machine operator, that is either
implemented by a direct C call or by platform specific code, i.e.
using the FPU on x64 and ia32.

This operator is used to implement Math.log as a proper TurboFan
builtin on top of the CodeStubAssembler.

Also introduce a NumberLog simplified operator on top of Float64Log
and use that for the fast inline path of Math.log inside TurboFan
optimized code.

BUG=v8:5065
==========

to

==========
[builtins] Migrate Math.log to TurboFan.

Introduce a dedicated Float64Log machine operator, that is either
implemented by a direct C call or by platform specific code, i.e.
using the FPU on x64 and ia32.

This operator is used to implement Math.log as a proper TurboFan
builtin on top of the CodeStubAssembler.

Also introduce a NumberLog simplified operator on top of Float64Log
and use that for the fast inline path of Math.log inside TurboFan
optimized code.

BUG=v8:5065
==========

[commit-bot: I haz the power, 2016-06-03 09:47:32]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-03 09:48:38]

Description was changed from

==========
[builtins] Migrate Math.log to TurboFan.

Introduce a dedicated Float64Log machine operator, that is either
implemented by a direct C call or by platform specific code, i.e.
using the FPU on x64 and ia32.

This operator is used to implement Math.log as a proper TurboFan
builtin on top of the CodeStubAssembler.

Also introduce a NumberLog simplified operator on top of Float64Log
and use that for the fast inline path of Math.log inside TurboFan
optimized code.

BUG=v8:5065
==========

to

==========
[builtins] Migrate Math.log to TurboFan.

Introduce a dedicated Float64Log machine operator, that is either
implemented by a direct C call or by platform specific code, i.e.
using the FPU on x64 and ia32.

This operator is used to implement Math.log as a proper TurboFan
builtin on top of the CodeStubAssembler.

Also introduce a NumberLog simplified operator on top of Float64Log
and use that for the fast inline path of Math.log inside TurboFan
optimized code.

BUG=v8:5065

Committed: https://crrev.com/f2da19fe393124c517f9949183e988e669e4f628
Cr-Commit-Position: refs/heads/master@{#36703}
==========

[commit-bot: I haz the power, 2016-06-03 09:48:39]

Patchset 3 (id:??) landed as
https://crrev.com/f2da19fe393124c517f9949183e988e669e4f628
Cr-Commit-Position: refs/heads/master@{#36703}