Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 2029403003: [Autofill] Truncate expiration year based on prediction and max length. (Closed)

Created:
4 years, 6 months ago by sebsg
Modified:
4 years, 6 months ago
Reviewers:
Mathieu
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

[Autofill] Truncate expiration year based on prediction and max length. Use the prediction type and max length attribute of the field to determine the number (if any) of character to truncate from the start of the expiration year when filling an input field. BUG=616174 TEST=AutofillFieldTest Review-Url: https://codereview.chromium.org/2025063002 Cr-Commit-Position: refs/heads/master@{#396956} (cherry picked from commit 103c242eb62e46367cc80dfbfa71ebbf4f9cbb10) NOTRY=true NOPRESUBMIT=true

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -0 lines) Patch
M components/autofill/core/browser/autofill_field.cc View 2 chunks +27 lines, -0 lines 0 comments Download
M components/autofill/core/browser/autofill_field_unittest.cc View 1 chunk +47 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2029403003/1
4 years, 6 months ago (2016-06-06 19:41:51 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 6 months ago (2016-06-06 19:41:54 UTC) #4
sebsg
PTAL?
4 years, 6 months ago (2016-06-06 19:42:54 UTC) #6
Mathieu
lgtm
4 years, 6 months ago (2016-06-06 19:52:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2029403003/1
4 years, 6 months ago (2016-06-06 19:54:15 UTC) #9
commit-bot: I haz the power
CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
4 years, 6 months ago (2016-06-06 19:54:17 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2029403003/1
4 years, 6 months ago (2016-06-06 19:56:42 UTC) #14
commit-bot: I haz the power
4 years, 6 months ago (2016-06-06 19:58:30 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698