Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 2025063002: [Autofill] Truncate expiration year based on prediction and max length. (Closed)

Created:
4 years, 6 months ago by sebsg
Modified:
4 years, 6 months ago
Reviewers:
Mathieu
CC:
bondd+autofillwatch_chromium.org, browser-components-watch_chromium.org, chromium-reviews, estade+watch_chromium.org, jdonnelly+autofillwatch_chromium.org, Justin Donnelly, rouslan+autofill_chromium.org, vabr+watchlistautofill_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use the prediction type and max length attribute of the field to determine the number (if any) of character to truncate from the start of the expiration year when filling an input field. BUG=616174 TEST=AutofillFieldTest Committed: https://crrev.com/103c242eb62e46367cc80dfbfa71ebbf4f9cbb10 Cr-Commit-Position: refs/heads/master@{#396956}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -0 lines) Patch
M components/autofill/core/browser/autofill_field.cc View 2 chunks +27 lines, -0 lines 0 comments Download
M components/autofill/core/browser/autofill_field_unittest.cc View 1 chunk +47 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
sebsg
PTAL?
4 years, 6 months ago (2016-05-31 20:29:37 UTC) #5
Mathieu
lgtm, top work!
4 years, 6 months ago (2016-05-31 20:34:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2025063002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2025063002/40001
4 years, 6 months ago (2016-05-31 21:10:39 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:40001)
4 years, 6 months ago (2016-05-31 22:37:01 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-05-31 22:38:40 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/103c242eb62e46367cc80dfbfa71ebbf4f9cbb10
Cr-Commit-Position: refs/heads/master@{#396956}

Powered by Google App Engine
This is Rietveld 408576698