Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(515)

Issue 2029393004: Fix runtime setting forcing passive event listeners to scroll blocking events. (Closed)

Created:
4 years, 6 months ago by dtapuska
Modified:
4 years, 6 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

Fix runtime setting forcing passive event listeners to scroll blocking events. Previously the runtime settings would apply to all events; make it restricted to scroll blocking events. Also adjust the blockedEventsWarning threshold to use this same event type (it was previously reporting touchend as well; which it shouldn't have) BUG=599611 Review-Url: https://codereview.chromium.org/2024913002 Cr-Commit-Position: refs/heads/master@{#396855} (cherry picked from commit b38d8cc6524ed76a371abb851f97e534aab04926) Committed: https://chromium.googlesource.com/chromium/src/+/244b55720606f9fccf929f4d3146972426f56e19

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -11 lines) Patch
M third_party/WebKit/Source/core/events/EventTarget.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/events/EventTarget.cpp View 4 chunks +18 lines, -10 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
dtapuska
4 years, 6 months ago (2016-06-03 13:19:49 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
244b55720606f9fccf929f4d3146972426f56e19.

Powered by Google App Engine
This is Rietveld 408576698