Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 2024913002: Fix runtime setting forcing passive event listeners to scroll blocking events. (Closed)

Created:
4 years, 6 months ago by dtapuska
Modified:
4 years, 6 months ago
Reviewers:
Rick Byers
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix runtime setting forcing passive event listeners to scroll blocking events. Previously the runtime settings would apply to all events; make it restricted to scroll blocking events. Also adjust the blockedEventsWarning threshold to use this same event type (it was previously reporting touchend as well; which it shouldn't have) BUG=599611 Committed: https://crrev.com/b38d8cc6524ed76a371abb851f97e534aab04926 Cr-Commit-Position: refs/heads/master@{#396855}

Patch Set 1 #

Patch Set 2 : Fix layout test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -14 lines) Patch
M third_party/WebKit/LayoutTests/inspector/input-event-warning.html View 1 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/input-event-warning-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/events/EventTarget.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/events/EventTarget.cpp View 4 chunks +18 lines, -10 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
dtapuska
Sorry this was a brain fart. I definitely tested that I was assigning all event ...
4 years, 6 months ago (2016-05-31 13:59:41 UTC) #3
Rick Byers
LGTM No worries, I also can't believe I missed this. When looking at the AMP ...
4 years, 6 months ago (2016-05-31 14:03:51 UTC) #4
Rick Byers
On 2016/05/31 14:03:51, Rick Byers wrote: > LGTM > > No worries, I also can't ...
4 years, 6 months ago (2016-05-31 14:04:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2024913002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2024913002/20001
4 years, 6 months ago (2016-05-31 17:34:13 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-05-31 17:38:31 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-05-31 17:39:41 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b38d8cc6524ed76a371abb851f97e534aab04926
Cr-Commit-Position: refs/heads/master@{#396855}

Powered by Google App Engine
This is Rietveld 408576698