Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Issue 2029343002: Link to DirectWrite directly, instead of calling LoadLibrary (Closed)

Created:
4 years, 6 months ago by Ilya Kulshin
Modified:
4 years, 5 months ago
Reviewers:
jam, scottmg
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Link to DirectWrite directly, instead of calling LoadLibrary BUG= Committed: https://crrev.com/7561063aa78a31c73506f666c9eeccf45fe3dc07 Cr-Commit-Position: refs/heads/master@{#403344}

Patch Set 1 #

Patch Set 2 : gn build #

Patch Set 3 : link content_child to dwrite #

Patch Set 4 : Fix build and remove delayload #

Patch Set 5 : Link gfx_unittests to dwrite #

Patch Set 6 : Link content_unittests to dwrite.dll #

Total comments: 2

Patch Set 7 : Rebase #

Patch Set 8 : Remove global IDWriteFactory #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -103 lines) Patch
M content/child/BUILD.gn View 1 2 3 4 5 6 1 chunk +4 lines, -0 lines 0 comments Download
M content/child/dwrite_font_proxy/dwrite_font_proxy_init_win.cc View 1 chunk +1 line, -21 lines 0 comments Download
M content/child/dwrite_font_proxy/dwrite_font_proxy_win_unittest.cc View 13 chunks +2 lines, -42 lines 0 comments Download
M content/child/dwrite_font_proxy/font_fallback_win_unittest.cc View 1 2 3 4 5 6 2 chunks +2 lines, -17 lines 0 comments Download
M content/content_child.gypi View 1 2 3 4 5 6 1 chunk +9 lines, -0 lines 0 comments Download
M content/content_tests.gypi View 1 2 3 4 5 6 1 chunk +7 lines, -0 lines 0 comments Download
M content/test/BUILD.gn View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M ui/gfx/BUILD.gn View 1 2 3 4 5 6 2 chunks +5 lines, -1 line 0 comments Download
M ui/gfx/font_fallback_win.cc View 1 2 3 4 5 6 7 2 chunks +3 lines, -6 lines 0 comments Download
M ui/gfx/gfx.gyp View 1 2 3 4 5 6 1 chunk +7 lines, -0 lines 0 comments Download
M ui/gfx/gfx_tests.gyp View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M ui/gfx/win/direct_write.cc View 1 2 3 4 5 1 chunk +6 lines, -16 lines 0 comments Download

Messages

Total messages: 20 (9 generated)
Ilya Kulshin
ptal Still need to wait for https://codereview.chromium.org/2054273002/ to land, but would like to get a ...
4 years, 5 months ago (2016-06-28 22:57:18 UTC) #4
scottmg
lgtm https://codereview.chromium.org/2029343002/diff/120001/content/child/dwrite_font_proxy/dwrite_font_proxy_win_unittest.cc File content/child/dwrite_font_proxy/dwrite_font_proxy_win_unittest.cc (left): https://codereview.chromium.org/2029343002/diff/120001/content/child/dwrite_font_proxy/dwrite_font_proxy_win_unittest.cc#oldcode46 content/child/dwrite_font_proxy/dwrite_font_proxy_win_unittest.cc:46: if (!factory) Were all these early outs because ...
4 years, 5 months ago (2016-06-28 23:22:45 UTC) #5
Ilya Kulshin
https://codereview.chromium.org/2029343002/diff/120001/content/child/dwrite_font_proxy/dwrite_font_proxy_win_unittest.cc File content/child/dwrite_font_proxy/dwrite_font_proxy_win_unittest.cc (left): https://codereview.chromium.org/2029343002/diff/120001/content/child/dwrite_font_proxy/dwrite_font_proxy_win_unittest.cc#oldcode46 content/child/dwrite_font_proxy/dwrite_font_proxy_win_unittest.cc:46: if (!factory) On 2016/06/28 23:22:45, scottmg wrote: > Were ...
4 years, 5 months ago (2016-06-28 23:42:50 UTC) #6
Ilya Kulshin
+jam@ - could you review ui/gfx/* and give owners approval for content/*/BUILD.gn scottmg@ - one ...
4 years, 5 months ago (2016-06-30 16:44:38 UTC) #10
scottmg
changes lgtm
4 years, 5 months ago (2016-06-30 17:02:46 UTC) #11
jam
lgtm
4 years, 5 months ago (2016-06-30 22:24:01 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2029343002/180001
4 years, 5 months ago (2016-06-30 23:10:43 UTC) #14
commit-bot: I haz the power
Committed patchset #8 (id:180001)
4 years, 5 months ago (2016-06-30 23:42:07 UTC) #16
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-06-30 23:42:10 UTC) #17
commit-bot: I haz the power
Patchset 8 (id:??) landed as https://crrev.com/7561063aa78a31c73506f666c9eeccf45fe3dc07 Cr-Commit-Position: refs/heads/master@{#403344}
4 years, 5 months ago (2016-06-30 23:45:07 UTC) #19
Ilya Kulshin
4 years, 5 months ago (2016-07-01 01:00:32 UTC) #20
Message was sent while issue was closed.
A revert of this CL (patchset #8 id:180001) has been created in
https://codereview.chromium.org/2117683002/ by kulshin@chromium.org.

The reason for reverting is: Breaks aura_demo target.

Powered by Google App Engine
This is Rietveld 408576698