third_party/WebKit/Source/modules/csspaint/PaintWorklet.h - Issue 2029163002: Worklets - Change inheritance heirarchy of WorkletGlobalScope

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/csspaint/PaintWorklet.h

Issue 2029163002: Worklets - Change inheritance heirarchy of WorkletGlobalScope (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix build 2 Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/core/v8/V8Binding.cpp ('K') | « third_party/WebKit/Source/core/workers/WorkletGlobalScopeProxy.h ('k') | third_party/WebKit/Source/modules/csspaint/PaintWorklet.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/csspaint/PaintWorklet.h

diff --git a/third_party/WebKit/Source/modules/csspaint/PaintWorklet.h b/third_party/WebKit/Source/modules/csspaint/PaintWorklet.h

index b4f66a1fee2f2713ea0eb8f19da8afa6c39a5403..351d91bc0c57bdc97d0d359745f06f52bde0c70b 100644

--- a/third_party/WebKit/Source/modules/csspaint/PaintWorklet.h

+++ b/third_party/WebKit/Source/modules/csspaint/PaintWorklet.h

@@ -21,10 +21,12 @@ public:

static PaintWorklet* create(LocalFrame*, ExecutionContext*);

~PaintWorklet() override;

- WorkletGlobalScope* workletGlobalScope() const final;

+ WorkletGlobalScopeProxy* workletGlobalScopeProxy() const final;

yhirano 2016/06/02 08:14:42 Why don't you return PaingWorkletGlobalScope* and

ikilpatrick 2016/06/02 18:26:00 Done.

CSSPaintDefinition* findDefinition(const String& name);

void addPendingGenerator(const String& name, CSSPaintImageGeneratorImpl*);

+ PaintWorkletGlobalScope* globalScopeForTesting() const { return m_paintWorkletGlobalScope.get(); }

DECLARE_VIRTUAL_TRACE();

private: