|
Previously the inheritance for WorkletGlobalScopes was:
core/workers/WorkerOrWorkletGlobalScope
-> core/workers/MainThreadWorkletGlobalScope
-> modules/worklet/WorkletGlobalScope
With ThreadedWorkletGlobalScope, not all global scopes will exist on the main thread.
MainThreadWorkletGlobalScope exists in core/workers as the MainThreadDebugger & friends need to access it's LocalFrame from core/
The new inheritance is:
core/workers/WorkerOrWorkletGlobalScope
-> core/workers/WorkletGlobalScope
-> core/workers/MainThreadWorkletGlobalScope
This moves WorkletGlobalScope into core and a few other classes. ThreadedWorkletGlobalScope will exist in modules and inherit from WorkletGlobalScope.
Implementation Doc:
https://docs.google.com/document/d/14hEO_BqQRBne3tBD2xghEEo02nz2csLqY4SS6x6rmjA/edit
BUG= 567358
Committed: https://crrev.com/b3a781795afd30e7c931ecf0a2276f76b411d58b
Cr-Commit-Position: refs/heads/master@{#397722}
Total comments: 4
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+120 lines, -281 lines) |
Patch |
|
M |
third_party/WebKit/Source/bindings/core/v8/V8Binding.cpp
|
View
|
1
2
3
4
5
6
7
8
|
4 chunks |
+7 lines, -11 lines |
0 comments
|
Download
|
|
M |
third_party/WebKit/Source/bindings/modules/v8/ModuleBindingsInitializer.cpp
|
View
|
1
2
3
4
5
|
2 chunks |
+0 lines, -2 lines |
0 comments
|
Download
|
|
M |
third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.h
|
View
|
1
2
3
4
5
|
1 chunk |
+0 lines, -2 lines |
0 comments
|
Download
|
|
M |
third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.cpp
|
View
|
1
2
3
4
5
6
|
4 chunks |
+0 lines, -15 lines |
0 comments
|
Download
|
|
M |
third_party/WebKit/Source/core/core.gypi
|
View
|
1
2
3
4
5
6
7
8
|
3 chunks |
+4 lines, -0 lines |
0 comments
|
Download
|
|
M |
third_party/WebKit/Source/core/dom/ExecutionContext.h
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
|
M |
third_party/WebKit/Source/core/inspector/InspectorInstrumentation.cpp
|
View
|
1
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp
|
View
|
1
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
D |
third_party/WebKit/Source/core/workers/MainThreadWorkletGlobalScope.h
|
View
|
1
2
3
4
5
|
1 chunk |
+18 lines, -6 lines |
0 comments
|
Download
|
|
A |
third_party/WebKit/Source/core/workers/MainThreadWorkletGlobalScope.cpp
|
View
|
1
|
1 chunk |
+38 lines, -0 lines |
0 comments
|
Download
|
|
A + |
third_party/WebKit/Source/core/workers/WorkletGlobalScope.h
|
View
|
1
|
3 chunks |
+6 lines, -9 lines |
0 comments
|
Download
|
|
A + |
third_party/WebKit/Source/core/workers/WorkletGlobalScope.cpp
|
View
|
1
|
4 chunks |
+5 lines, -12 lines |
0 comments
|
Download
|
|
A + |
third_party/WebKit/Source/core/workers/WorkletGlobalScope.idl
|
View
|
1
|
0 chunks |
+-1 lines, --1 lines |
0 comments
|
Download
|
|
A |
third_party/WebKit/Source/core/workers/WorkletGlobalScopeProxy.h
|
View
|
1
2
3
4
5
6
7
|
1 chunk |
+24 lines, -0 lines |
0 comments
|
Download
|
|
M |
third_party/WebKit/Source/modules/csspaint/PaintWorklet.h
|
View
|
1
2
3
4
5
6
|
3 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
third_party/WebKit/Source/modules/csspaint/PaintWorklet.cpp
|
View
|
1
2
3
4
5
6
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
third_party/WebKit/Source/modules/csspaint/PaintWorkletGlobalScope.h
|
View
|
1
|
2 chunks |
+4 lines, -3 lines |
0 comments
|
Download
|
|
M |
third_party/WebKit/Source/modules/csspaint/PaintWorkletGlobalScope.cpp
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
third_party/WebKit/Source/modules/csspaint/PaintWorkletTest.cpp
|
View
|
1
2
3
4
5
6
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
third_party/WebKit/Source/modules/modules.gypi
|
View
|
1
2
3
4
5
6
7
8
|
2 chunks |
+0 lines, -3 lines |
0 comments
|
Download
|
|
M |
third_party/WebKit/Source/modules/worklet/Worklet.h
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
third_party/WebKit/Source/modules/worklet/Worklet.cpp
|
View
|
1
|
3 chunks |
+4 lines, -5 lines |
0 comments
|
Download
|
|
M |
third_party/WebKit/Source/modules/worklet/WorkletGlobalScope.h
|
View
|
1
|
1 chunk |
+0 lines, -85 lines |
0 comments
|
Download
|
|
M |
third_party/WebKit/Source/modules/worklet/WorkletGlobalScope.cpp
|
View
|
1
|
1 chunk |
+0 lines, -103 lines |
0 comments
|
Download
|
|
D |
third_party/WebKit/Source/modules/worklet/WorkletGlobalScope.idl
|
View
|
1
|
1 chunk |
+0 lines, -16 lines |
0 comments
|
Download
|
Total messages: 16 (7 generated)
|