Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 2029163002: Worklets - Change inheritance heirarchy of WorkletGlobalScope (Closed)

Created:
4 years, 6 months ago by ikilpatrick
Modified:
4 years, 6 months ago
Reviewers:
kinuko, haraken, yhirano
CC:
chromium-reviews, kinuko+worker_chromium.org, caseq+blink_chromium.org, pfeldman+blink_chromium.org, horo+watch_chromium.org, sof, eae+blinkwatch, lushnikov+blink_chromium.org, falken, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews-bindings_chromium.org, devtools-reviews_chromium.org, blink-reviews, apavlov+blink_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org, blink-worker-reviews_chromium.org, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Previously the inheritance for WorkletGlobalScopes was: core/workers/WorkerOrWorkletGlobalScope -> core/workers/MainThreadWorkletGlobalScope -> modules/worklet/WorkletGlobalScope With ThreadedWorkletGlobalScope, not all global scopes will exist on the main thread. MainThreadWorkletGlobalScope exists in core/workers as the MainThreadDebugger & friends need to access it's LocalFrame from core/ The new inheritance is: core/workers/WorkerOrWorkletGlobalScope -> core/workers/WorkletGlobalScope -> core/workers/MainThreadWorkletGlobalScope This moves WorkletGlobalScope into core and a few other classes. ThreadedWorkletGlobalScope will exist in modules and inherit from WorkletGlobalScope. Implementation Doc: https://docs.google.com/document/d/14hEO_BqQRBne3tBD2xghEEo02nz2csLqY4SS6x6rmjA/edit BUG=567358 Committed: https://crrev.com/b3a781795afd30e7c931ecf0a2276f76b411d58b Cr-Commit-Position: refs/heads/master@{#397722}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : fix build. #

Patch Set 6 : fix build 2 #

Total comments: 4

Patch Set 7 : #

Patch Set 8 : fix msvc build. #

Patch Set 9 : rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -281 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/V8Binding.cpp View 1 2 3 4 5 6 7 8 4 chunks +7 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/bindings/modules/v8/ModuleBindingsInitializer.cpp View 1 2 3 4 5 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.h View 1 2 3 4 5 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.cpp View 1 2 3 4 5 6 4 chunks +0 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/core/core.gypi View 1 2 3 4 5 6 7 8 3 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ExecutionContext.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorInstrumentation.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/Source/core/workers/MainThreadWorkletGlobalScope.h View 1 2 3 4 5 1 chunk +18 lines, -6 lines 0 comments Download
A third_party/WebKit/Source/core/workers/MainThreadWorkletGlobalScope.cpp View 1 1 chunk +38 lines, -0 lines 0 comments Download
A + third_party/WebKit/Source/core/workers/WorkletGlobalScope.h View 1 3 chunks +6 lines, -9 lines 0 comments Download
A + third_party/WebKit/Source/core/workers/WorkletGlobalScope.cpp View 1 4 chunks +5 lines, -12 lines 0 comments Download
A + third_party/WebKit/Source/core/workers/WorkletGlobalScope.idl View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A third_party/WebKit/Source/core/workers/WorkletGlobalScopeProxy.h View 1 2 3 4 5 6 7 1 chunk +24 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/csspaint/PaintWorklet.h View 1 2 3 4 5 6 3 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/csspaint/PaintWorklet.cpp View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/csspaint/PaintWorkletGlobalScope.h View 1 2 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/csspaint/PaintWorkletGlobalScope.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/csspaint/PaintWorkletTest.cpp View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/modules.gypi View 1 2 3 4 5 6 7 8 2 chunks +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/worklet/Worklet.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/worklet/Worklet.cpp View 1 3 chunks +4 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/worklet/WorkletGlobalScope.h View 1 1 chunk +0 lines, -85 lines 0 comments Download
M third_party/WebKit/Source/modules/worklet/WorkletGlobalScope.cpp View 1 1 chunk +0 lines, -103 lines 0 comments Download
D third_party/WebKit/Source/modules/worklet/WorkletGlobalScope.idl View 1 1 chunk +0 lines, -16 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
ikilpatrick
Moving WorkletGlobalScope to core prevents adding a worklet only method to WorkerOrWorkletGlobalScope (for accessing frame() ...
4 years, 6 months ago (2016-06-02 04:24:19 UTC) #4
kinuko
lgtm (win bot seems to be having compile error)
4 years, 6 months ago (2016-06-02 07:42:03 UTC) #5
haraken
LGTM
4 years, 6 months ago (2016-06-02 07:50:25 UTC) #6
yhirano
https://codereview.chromium.org/2029163002/diff/100001/third_party/WebKit/Source/bindings/core/v8/V8Binding.cpp File third_party/WebKit/Source/bindings/core/v8/V8Binding.cpp (right): https://codereview.chromium.org/2029163002/diff/100001/third_party/WebKit/Source/bindings/core/v8/V8Binding.cpp#newcode720 third_party/WebKit/Source/bindings/core/v8/V8Binding.cpp:720: return V8WorkerGlobalScope::toImpl(workletWrapper)->getExecutionContext(); Shouldn't this be V8WorkletGlobalScope? https://codereview.chromium.org/2029163002/diff/100001/third_party/WebKit/Source/modules/csspaint/PaintWorklet.h File third_party/WebKit/Source/modules/csspaint/PaintWorklet.h ...
4 years, 6 months ago (2016-06-02 08:14:42 UTC) #7
ikilpatrick
Thanks Yutaka! win compile now works as well. https://codereview.chromium.org/2029163002/diff/100001/third_party/WebKit/Source/bindings/core/v8/V8Binding.cpp File third_party/WebKit/Source/bindings/core/v8/V8Binding.cpp (right): https://codereview.chromium.org/2029163002/diff/100001/third_party/WebKit/Source/bindings/core/v8/V8Binding.cpp#newcode720 third_party/WebKit/Source/bindings/core/v8/V8Binding.cpp:720: return ...
4 years, 6 months ago (2016-06-02 18:26:00 UTC) #8
yhirano
lgtm
4 years, 6 months ago (2016-06-03 05:39:07 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2029163002/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2029163002/160001
4 years, 6 months ago (2016-06-03 15:39:10 UTC) #12
commit-bot: I haz the power
Committed patchset #9 (id:160001)
4 years, 6 months ago (2016-06-03 16:21:38 UTC) #14
commit-bot: I haz the power
4 years, 6 months ago (2016-06-03 16:24:16 UTC) #16
Message was sent while issue was closed.
Patchset 9 (id:??) landed as
https://crrev.com/b3a781795afd30e7c931ecf0a2276f76b411d58b
Cr-Commit-Position: refs/heads/master@{#397722}

Powered by Google App Engine
This is Rietveld 408576698