Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Issue 2028863002: DevTools: fix css pretty-print. (Closed)

Created:
4 years, 6 months ago by lushnikov
Modified:
4 years, 6 months ago
Reviewers:
dgozman
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

DevTools: fix css pretty-print. The CSS pretty-printing was regressed back in the days when all formatters were moved to a single content builder. The content builder assumes that added tokens are "words" - and makes sure those do not stick together. However, CSS formatter violates this contract. This patch is a workaround which could be merged. BUG=614678 R=dgozman Review-Url: https://codereview.chromium.org/2012953002 Cr-Commit-Position: refs/heads/master@{#396332} (cherry picked from commit aec0b6fa92b2f2bece418aede111a78b043a0655) Committed: https://chromium.googlesource.com/chromium/src/+/88787769105668050fd2958e860dd8835ce01357

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+344 lines, -149 lines) Patch
D third_party/WebKit/LayoutTests/inspector/sources/pretty-print-css.html View 1 chunk +0 lines, -64 lines 0 comments Download
A + third_party/WebKit/LayoutTests/inspector/sources/pretty-print-css-1.html View 3 chunks +9 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/inspector/sources/pretty-print-css-1-expected.txt View 3 chunks +22 lines, -1 line 0 comments Download
A third_party/WebKit/LayoutTests/inspector/sources/pretty-print-css-2.html View 1 chunk +59 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector/sources/pretty-print-css-2-expected.txt View 1 chunk +89 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector/sources/pretty-print-css-3.html View 1 chunk +59 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector/sources/pretty-print-css-3-expected.txt View 1 chunk +87 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector/sources/pretty-print-css-expected.txt View 1 chunk +0 lines, -81 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/formatter_worker/CSSFormatter.js View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/formatter_worker/FormattedContentBuilder.js View 1 chunk +13 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/formatter_worker/FormatterWorker.js View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
lushnikov
4 years, 6 months ago (2016-05-31 21:56:31 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
88787769105668050fd2958e860dd8835ce01357.

Powered by Google App Engine
This is Rietveld 408576698