Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2012953002: DevTools: fix css pretty-print. (Closed)

Created:
4 years, 7 months ago by lushnikov
Modified:
4 years, 6 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: fix css pretty-print. The CSS pretty-printing was regressed back in the days when all formatters were moved to a single content builder. The content builder assumes that added tokens are "words" - and makes sure those do not stick together. However, CSS formatter violates this contract. This patch is a workaround which could be merged. BUG=614678 R=dgozman Committed: https://crrev.com/aec0b6fa92b2f2bece418aede111a78b043a0655 Cr-Commit-Position: refs/heads/master@{#396332}

Patch Set 1 #

Total comments: 2

Patch Set 2 : address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+344 lines, -149 lines) Patch
D third_party/WebKit/LayoutTests/inspector/sources/pretty-print-css.html View 1 chunk +0 lines, -64 lines 0 comments Download
A + third_party/WebKit/LayoutTests/inspector/sources/pretty-print-css-1.html View 1 3 chunks +9 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/inspector/sources/pretty-print-css-1-expected.txt View 1 3 chunks +22 lines, -1 line 0 comments Download
A third_party/WebKit/LayoutTests/inspector/sources/pretty-print-css-2.html View 1 chunk +59 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector/sources/pretty-print-css-2-expected.txt View 1 chunk +89 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector/sources/pretty-print-css-3.html View 1 chunk +59 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector/sources/pretty-print-css-3-expected.txt View 1 chunk +87 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector/sources/pretty-print-css-expected.txt View 1 chunk +0 lines, -81 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/formatter_worker/CSSFormatter.js View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/formatter_worker/FormattedContentBuilder.js View 1 chunk +13 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/formatter_worker/FormatterWorker.js View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
lushnikov
please, take a look
4 years, 7 months ago (2016-05-25 23:27:01 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2012953002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2012953002/1
4 years, 7 months ago (2016-05-25 23:27:43 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-26 03:04:39 UTC) #5
commit-bot: I haz the power
Dry run: None
4 years, 7 months ago (2016-05-26 03:04:52 UTC) #6
lushnikov
ping
4 years, 7 months ago (2016-05-26 17:51:35 UTC) #7
dgozman
lgtm https://codereview.chromium.org/2012953002/diff/1/third_party/WebKit/LayoutTests/inspector/sources/pretty-print-css-1-expected.txt File third_party/WebKit/LayoutTests/inspector/sources/pretty-print-css-1-expected.txt (right): https://codereview.chromium.org/2012953002/diff/1/third_party/WebKit/LayoutTests/inspector/sources/pretty-print-css-1-expected.txt#newcode86 third_party/WebKit/LayoutTests/inspector/sources/pretty-print-css-1-expected.txt:86: a.b.c:hover,.d.e.f.g::before,h.i { Let's have a test with this ...
4 years, 7 months ago (2016-05-26 19:37:43 UTC) #8
lushnikov
https://codereview.chromium.org/2012953002/diff/1/third_party/WebKit/LayoutTests/inspector/sources/pretty-print-css-1-expected.txt File third_party/WebKit/LayoutTests/inspector/sources/pretty-print-css-1-expected.txt (right): https://codereview.chromium.org/2012953002/diff/1/third_party/WebKit/LayoutTests/inspector/sources/pretty-print-css-1-expected.txt#newcode86 third_party/WebKit/LayoutTests/inspector/sources/pretty-print-css-1-expected.txt:86: a.b.c:hover,.d.e.f.g::before,h.i { On 2016/05/26 19:37:43, dgozman wrote: > Let's ...
4 years, 7 months ago (2016-05-26 19:44:58 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2012953002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2012953002/20001
4 years, 7 months ago (2016-05-26 19:45:34 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-05-27 00:39:27 UTC) #13
commit-bot: I haz the power
4 years, 6 months ago (2016-05-27 00:40:47 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/aec0b6fa92b2f2bece418aede111a78b043a0655
Cr-Commit-Position: refs/heads/master@{#396332}

Powered by Google App Engine
This is Rietveld 408576698