Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 2028833002: [Extensions] Expand capabilities to about:blank iframes within a page (Closed)

Created:
4 years, 6 months ago by Devlin
Modified:
4 years, 6 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

[Extensions] Expand capabilities to about:blank iframes within a page Expand the content capabilies to grant the capabilities to about:blank iframes within a page that matches the content capabilities entry for an extension. This is consistent with most web permissions, where about:blank frames take the permissions from the "parent". In theory, we could also create a match_about_blank entry in the manifest for this, but I'm not sure how many use cases there are for *not* granting permissions to child frames like this. BUG=599900 Review-Url: https://codereview.chromium.org/1985323002 Cr-Commit-Position: refs/heads/master@{#395744} (cherry picked from commit d0f2bad624766048836545ab34e13cd7a46c92e8) Committed: https://chromium.googlesource.com/chromium/src/+/c696c1e934654abe2b5362396c6c996c3a9dffeb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -1 line) Patch
M chrome/browser/extensions/content_capabilities_browsertest.cc View 3 chunks +27 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/content_capabilities/bar.example.com.html View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/content_capabilities/capability_tests.js View 2 chunks +12 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/content_capabilities/foo.example.com.html View 1 chunk +6 lines, -0 lines 0 comments Download
M extensions/renderer/dispatcher.cc View 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
Devlin
4 years, 6 months ago (2016-05-31 20:52:07 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c696c1e934654abe2b5362396c6c996c3a9dffeb.

Powered by Google App Engine
This is Rietveld 408576698