Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2200)

Unified Diff: chrome/browser/extensions/content_capabilities_browsertest.cc

Issue 2028833002: [Extensions] Expand capabilities to about:blank iframes within a page (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2743
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/test/data/extensions/content_capabilities/bar.example.com.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/content_capabilities_browsertest.cc
diff --git a/chrome/browser/extensions/content_capabilities_browsertest.cc b/chrome/browser/extensions/content_capabilities_browsertest.cc
index a33169c8d2109e0e8667f545c6e52e80ed0ac528..881f9b5354d1323f9fd6633e57035ab1edf775a6 100644
--- a/chrome/browser/extensions/content_capabilities_browsertest.cc
+++ b/chrome/browser/extensions/content_capabilities_browsertest.cc
@@ -129,6 +129,20 @@ class ContentCapabilitiesTest : public ExtensionApiTest {
return TestScriptResult(extension, url, "tests.canWriteClipboard()");
}
+ testing::AssertionResult CanReadClipboardInAboutBlankFrame(
+ const Extension* extension,
+ const GURL& url) {
+ return TestScriptResult(extension, url,
+ "tests.canReadClipboardInAboutBlankFrame()");
+ }
+
+ testing::AssertionResult CanWriteClipboardInAboutBlankFrame(
+ const Extension* extension,
+ const GURL& url) {
+ return TestScriptResult(extension, url,
+ "tests.canWriteClipboardInAboutBlankFrame()");
+ }
+
testing::AssertionResult HasUnlimitedStorage(const Extension* extension,
const GURL& url) {
if (profile()->GetSpecialStoragePolicy()->IsStorageUnlimited(url))
@@ -162,6 +176,12 @@ IN_PROC_BROWSER_TEST_F(ContentCapabilitiesTest, ClipboardRead) {
CanReadClipboard(extension.get(), GetTestURLFor("foo.example.com")));
EXPECT_FALSE(
CanReadClipboard(extension.get(), GetTestURLFor("bar.example.com")));
+ EXPECT_TRUE(
+ CanReadClipboardInAboutBlankFrame(extension.get(),
+ GetTestURLFor("foo.example.com")));
+ EXPECT_FALSE(
+ CanReadClipboardInAboutBlankFrame(extension.get(),
+ GetTestURLFor("bar.example.com")));
// TODO(dcheng): This should be false, but we cannot currently execute testing
// script without a user gesture.
EXPECT_TRUE(
@@ -174,10 +194,17 @@ IN_PROC_BROWSER_TEST_F(ContentCapabilitiesTest, ClipboardWrite) {
MakeJSONList("http://foo.example.com/*"), MakeJSONList("clipboardWrite"));
EXPECT_TRUE(
CanWriteClipboard(extension.get(), GetTestURLFor("foo.example.com")));
+ EXPECT_TRUE(
+ CanWriteClipboardInAboutBlankFrame(extension.get(),
+ GetTestURLFor("foo.example.com")));
// TODO(dcheng): This should be false, but we cannot currently execute testing
// script without a user gesture.
EXPECT_TRUE(
CanWriteClipboard(extension.get(), GetTestURLFor("bar.example.com")));
+ EXPECT_TRUE(
+ CanWriteClipboardInAboutBlankFrame(extension.get(),
+ GetTestURLFor("bar.example.com")));
+
EXPECT_FALSE(
CanReadClipboard(extension.get(), GetTestURLFor("foo.example.com")));
}
« no previous file with comments | « no previous file | chrome/test/data/extensions/content_capabilities/bar.example.com.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698