Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 202883002: Revert 169394 "Node::setTextContent should avoid work when nothi..." (Closed)

Created:
6 years, 9 months ago by Zhenyao Mo
Modified:
6 years, 9 months ago
Reviewers:
eseidel
CC:
blink-reviews, Paweł Hajdan Jr.
Visibility:
Public.

Description

Revert 169394 "Node::setTextContent should avoid work when nothi..." Might have broken countless layout tests (ok I am exaggerating) on almost all platforms > Node::setTextContent should avoid work when nothing changes > > We already had code to handle this case, which is shared > by editing as well as HTMLElement::setInnerText. > > replaceChildrenWithText does the right thing to avoid > doing work when the text content hasn't changed, etc. > > BUG=352836 > R=jchaffraix@chromium.org > > Review URL: https://codereview.chromium.org/200763006 TBR=eseidel@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169401

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -14 lines) Patch
D trunk/LayoutTests/fast/repaint/set-text-content-same.html View 1 chunk +0 lines, -10 lines 0 comments Download
D trunk/LayoutTests/fast/repaint/set-text-content-same-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M trunk/Source/core/dom/Node.cpp View 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Zhenyao Mo
6 years, 9 months ago (2014-03-18 00:38:46 UTC) #1
Zhenyao Mo
Committed patchset #1 manually as r169401.
6 years, 9 months ago (2014-03-18 00:38:58 UTC) #2
eseidel
The linux bubble shows green on https://codereview.chromium.org/200763006. The mac and win bubbles looked like the ...
6 years, 9 months ago (2014-03-18 00:40:44 UTC) #3
eseidel
The linux bubble shows green on https://codereview.chromium.org/200763006. The mac and win bubbles looked like the ...
6 years, 9 months ago (2014-03-18 00:40:45 UTC) #4
Zhenyao Mo
6 years, 9 months ago (2014-03-18 01:48:14 UTC) #5
Message was sent while issue was closed.
On 2014/03/18 00:40:45, eseidel wrote:
> The linux bubble shows green on https://codereview.chromium.org/200763006. 
The
> mac and win bubbles looked like the try-bots were just hosed.  So I landed
> manually.
> 
> I can investigate later if it turns out reverting this fixes your problems.

Yeah, it's this CL.

Powered by Google App Engine
This is Rietveld 408576698