trunk/Source/core/dom/Node.cpp - Issue 202883002: Revert 169394 "Node::setTextContent should avoid work when nothi..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: trunk/Source/core/dom/Node.cpp

Issue 202883002: Revert 169394 "Node::setTextContent should avoid work when nothi..." (Closed) Base URL: svn://svn.chromium.org/blink/

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: trunk/Source/core/dom/Node.cpp

===================================================================

--- trunk/Source/core/dom/Node.cpp (revision 169400)

+++ trunk/Source/core/dom/Node.cpp (working copy)

@@ -59,7 +59,6 @@

#include "core/dom/shadow/InsertionPoint.h"

#include "core/dom/shadow/ShadowRoot.h"

#include "core/editing/htmlediting.h"

-#include "core/editing/markup.h"

#include "core/events/BeforeLoadEvent.h"

#include "core/events/Event.h"

#include "core/events/EventDispatchMediator.h"

@@ -1498,7 +1497,11 @@

case ELEMENT_NODE:

case ATTRIBUTE_NODE:

case DOCUMENT_FRAGMENT_NODE: {

- replaceChildrenWithText(toContainerNode(this), text, ASSERT_NO_EXCEPTION);

+ RefPtr<ContainerNode> container = toContainerNode(this);

+ ChildListMutationScope mutation(*this);

+ container->removeChildren();

+ if (!text.isEmpty())

+ container->appendChild(document().createTextNode(text), ASSERT_NO_EXCEPTION);

return;

}

case DOCUMENT_NODE:

« no previous file with comments | « trunk/LayoutTests/fast/repaint/set-text-content-same-expected.txt ('k') | no next file » | no next file with comments »