Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(858)

Unified Diff: content/public/browser/content_browser_client.h

Issue 2028823002: Refactor to make BlimpLocationProvider accessible to content layer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Response to mvanouwerkerk's #21-1, #26 (partial) comments Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/content_browser_client.h
diff --git a/content/public/browser/content_browser_client.h b/content/public/browser/content_browser_client.h
index 7a61399c7d788336dfba16b3a9796183d0ef96da..e5910bf852c244037d70e4bf7a7ae8bb2ab6606d 100644
--- a/content/public/browser/content_browser_client.h
+++ b/content/public/browser/content_browser_client.h
@@ -621,6 +621,10 @@ class CONTENT_EXPORT ContentBrowserClient {
// information.
Wez 2016/06/01 21:45:19 nit: Now that we're actually using this in Chromiu
CJ 2016/06/01 22:37:10 Maybe keep it in case a refactor removes our use c
Wez 2016/06/10 23:40:34 Acknowledged.
virtual LocationProvider* OverrideSystemLocationProvider();
+ // Indicates that LocationProviders normally used by a process should be
+ // used.
Wez 2016/06/01 21:45:19 Not sure what "used by a process" means here. I'd
CJ 2016/06/01 22:37:10 It doesn't really fall back on it though? If true,
Wez 2016/06/10 23:40:34 Looks good - you might say "... in addition to the
CJ 2016/06/13 23:45:20 Done.
+ virtual bool UseDefaultLocationProviders();
+
// Creates a new DevToolsManagerDelegate. The caller owns the returned value.
// It's valid to return nullptr.
virtual DevToolsManagerDelegate* GetDevToolsManagerDelegate();

Powered by Google App Engine
This is Rietveld 408576698