Refactor to make BlimpLocationProvider accessible to content layer.

content/public/browser/content_browser_client.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_BROWSER_CONTENT_BROWSER_CLIENT_H_
 #define CONTENT_PUBLIC_BROWSER_CONTENT_BROWSER_CLIENT_H_
 
 #include <stddef.h>
 
 #include <map>
@@ skipping 600 matching lines @@
   // FileSystemBackends, and SpecialStoragePolicy for permission granting.
   virtual void GetAdditionalFileSystemBackends(
       BrowserContext* browser_context,
       const base::FilePath& storage_partition_path,
       ScopedVector<storage::FileSystemBackend>* additional_backends) {}
 
   // Allows an embedder to return its own LocationProvider implementation.
   // Return nullptr to use the default one for the platform to be created.
   // FYI: Used by an external project; please don't remove.
   // Contact Viatcheslav Ostapenko at sl.ostapenko@samsung.com for more
   // information.

[Wez, 2016/06/01 21:45:19]

nit: Now that we're actually using this in Chromium we could consider removing
this comment?

[CJ, 2016/06/01 22:37:10]

Maybe keep it in case a refactor removes our use case? 

[Wez, 2016/06/10 23:40:34]

Acknowledged.

   virtual LocationProvider* OverrideSystemLocationProvider();
 
+  // Indicates that LocationProviders normally used by a process should be
+  // used.

[Wez, 2016/06/01 21:45:19]

Not sure what "used by a process" means here.

I'd suggest something like "Returns true if the location API should fall-back to
using network-based location approximation." or similar.

[CJ, 2016/06/01 22:37:10]

It doesn't really fall back on it though? If true, we use it in addition to the
SystemLocationProvider. I did update the comment though. Let me know if you
think this suffices. 

[Wez, 2016/06/10 23:40:34]

Looks good - you might say "... in addition to the system provider, if any."

[CJ, 2016/06/13 23:45:20]

Done.

+  virtual bool UseDefaultLocationProviders();
+
   // Creates a new DevToolsManagerDelegate. The caller owns the returned value.
   // It's valid to return nullptr.
   virtual DevToolsManagerDelegate* GetDevToolsManagerDelegate();
 
   // Creates a new TracingDelegate. The caller owns the returned value.
   // It's valid to return nullptr.
   virtual TracingDelegate* GetTracingDelegate();
 
   // Returns true if plugin referred to by the url can use
   // pp::FileIO::RequestOSFileHandle.
@@ skipping 143 matching lines @@
   // Allows an embedder to provide its own ExternalVideoSurfaceContainer
   // implementation.  Return nullptr to disable external surface video.
   virtual ExternalVideoSurfaceContainer*
   OverrideCreateExternalVideoSurfaceContainer(WebContents* web_contents);
 #endif
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_BROWSER_CONTENT_BROWSER_CLIENT_H_