content/browser/geolocation/location_arbitrator_impl.h - Issue 2028823002: Refactor to make BlimpLocationProvider accessible to content layer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/geolocation/location_arbitrator_impl.h

Issue 2028823002: Refactor to make BlimpLocationProvider accessible to content layer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addresses kmarshall's and mvanouwerkerk's comments + code clean up Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/geolocation/geolocation_provider_impl.cc ('K') | « content/browser/geolocation/geolocation_provider_impl.cc ('k') | content/browser/geolocation/location_arbitrator_impl.cc » ('j') | content/browser/geolocation/location_arbitrator_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/geolocation/location_arbitrator_impl.h

diff --git a/content/browser/geolocation/location_arbitrator_impl.h b/content/browser/geolocation/location_arbitrator_impl.h

index 60c9ac57a905d817611ca6e92531187aaa508083..16048695b3f7b8bc9a2cedf97e20db5b5cd15d72 100644

--- a/content/browser/geolocation/location_arbitrator_impl.h

+++ b/content/browser/geolocation/location_arbitrator_impl.h

@@ -68,6 +68,7 @@ class CONTENT_EXPORT LocationArbitratorImpl : public LocationArbitrator {

// Takes ownership of |provider| on entry; it will either be added to

// |providers_| or deleted on error (e.g. it fails to start).

void RegisterProvider(LocationProvider* provider);

Wez 2016/06/10 23:40:34 nit: Since we're already modifying this header, co

CJ 2016/06/13 23:45:20 Done.

+ void RegisterSystemProvider();

Kevin M 2016/06/09 20:36:44 Separate functions w/leading comments with a newli

CJ 2016/06/09 23:07:06 Done.

void OnAccessTokenStoresLoaded(

AccessTokenStore::AccessTokenMap access_token_map,

net::URLRequestContextGetter* context_getter);