Refactor to make BlimpLocationProvider accessible to content layer.

content/browser/geolocation/location_arbitrator_impl.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_GEOLOCATION_LOCATION_ARBITRATOR_IMPL_H_
 #define CONTENT_BROWSER_GEOLOCATION_LOCATION_ARBITRATOR_IMPL_H_
 
 #include <stdint.h>
 
 #include "base/callback_forward.h"
@@ skipping 49 matching lines @@
       AccessTokenStore* access_token_store,
       net::URLRequestContextGetter* context,
       const GURL& url,
       const base::string16& access_token);
   virtual LocationProvider* NewSystemLocationProvider();
   virtual base::Time GetTimeNow() const;
 
  private:
   // Takes ownership of |provider| on entry; it will either be added to
   // |providers_| or deleted on error (e.g. it fails to start).
   void RegisterProvider(LocationProvider* provider);

[Wez, 2016/06/10 23:40:34]

nit: Since we're already modifying this header, could you tweak this to take a
unique_ptr - then you can trim the comment down to just the "added or deleted"
aspect.

[CJ, 2016/06/13 23:45:20]

Done.

+  void RegisterSystemProvider();

[Kevin M, 2016/06/09 20:36:44]

Separate functions w/leading comments with a newline.

Can you add a comment for your new function?

[CJ, 2016/06/09 23:07:06]

Done.

   void OnAccessTokenStoresLoaded(
       AccessTokenStore::AccessTokenMap access_token_map,
       net::URLRequestContextGetter* context_getter);
   void DoStartProviders();
 
   // Gets called when a provider has a new position.
   void OnLocationUpdate(const LocationProvider* provider,
                         const Geoposition& new_position);
 
   // Returns true if |new_position| is an improvement over |old_position|.
@@ skipping 20 matching lines @@
   DISALLOW_COPY_AND_ASSIGN(LocationArbitratorImpl);
 };
 
 // Factory functions for the various types of location provider to abstract
 // over the platform-dependent implementations.
 LocationProvider* NewSystemLocationProvider();
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_GEOLOCATION_LOCATION_ARBITRATOR_IMPL_H_