Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Unified Diff: chrome/browser/task_management/task_manager_observer.h

Issue 2028753002: Make Task Manager sort more meaningful (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix unittest Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/task_management/task_manager_interface.h ('k') | chrome/chrome_tests_unit.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/task_management/task_manager_observer.h
diff --git a/chrome/browser/task_management/task_manager_observer.h b/chrome/browser/task_management/task_manager_observer.h
index 875c61b365ecfb4c3631092b6b4003fa4021763d..04d80475f21790df901fea157baaa6e6f8bb5ec3 100644
--- a/chrome/browser/task_management/task_manager_observer.h
+++ b/chrome/browser/task_management/task_manager_observer.h
@@ -73,13 +73,13 @@ class TaskManagerObserver {
// Notifies the observer that a chrome task with |id| has started and the task
// manager is now monitoring it. The resource usage of this newly-added task
// will remain invalid until the next refresh cycle of the task manager.
- virtual void OnTaskAdded(TaskId id) = 0;
+ virtual void OnTaskAdded(TaskId id) {}
// Notifies the observer that a chrome task with |id| is about to be destroyed
// and removed from the task manager right after this call. Observers which
// are interested in doing some calculations related to the resource usage of
// this task upon its removal may do so inside this call.
- virtual void OnTaskToBeRemoved(TaskId id) = 0;
+ virtual void OnTaskToBeRemoved(TaskId id) {}
// Notifies the observer that the task manager has just finished a refresh
// cycle to calculate the resources usage of all tasks whose IDs are given in
@@ -87,7 +87,7 @@ class TaskManagerObserver {
// browser process is at the top of the list and the rest of the IDs will be
// sorted by the process IDs on which the tasks are running, then by the task
// IDs themselves.
- virtual void OnTasksRefreshed(const TaskIdList& task_ids) = 0;
+ virtual void OnTasksRefreshed(const TaskIdList& task_ids) {}
// Notifies the observer that the task manager has just finished a refresh
// cycle that calculated all the resource usage of all tasks whose IDs are in
« no previous file with comments | « chrome/browser/task_management/task_manager_interface.h ('k') | chrome/chrome_tests_unit.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698