Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3799)

Unified Diff: chrome/browser/task_management/task_manager_interface.h

Issue 2028753002: Make Task Manager sort more meaningful (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix unittest Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/task_management/task_manager_interface.h
diff --git a/chrome/browser/task_management/task_manager_interface.h b/chrome/browser/task_management/task_manager_interface.h
index cb947487082aea7f29ba7901122899daffea80c6..e021bd6f7bfb0092a6fe09ea8366bf37ba3e0f5e 100644
--- a/chrome/browser/task_management/task_manager_interface.h
+++ b/chrome/browser/task_management/task_manager_interface.h
@@ -189,10 +189,12 @@ class TaskManagerInterface {
TaskId task_id,
blink::WebCache::ResourceTypeStats* stats) const = 0;
- // Gets the list of task IDs currently tracked by the task manager. The list
- // will be sorted such that the task representing the browser process is at
- // the top of the list and the rest of the IDs will be sorted by the process
- // IDs on which the tasks are running, then by the task IDs themselves.
+ // Gets the list of task IDs currently tracked by the task manager. Tasks that
+ // share the same process id will always be consecutive. The list will be
+ // sorted in a way that reflects the process tree: the browser process will be
+ // first, followed by the gpu process if it exists. Related processes (e.g., a
+ // subframe process and its parent) will be kept together if possible. Callers
+ // can expect this ordering to be stable when a process is added or removed.
virtual const TaskIdList& GetTaskIdsList() const = 0;
// Gets the list of task IDs of the tasks that run on the same process as the
« no previous file with comments | « chrome/browser/task_management/task_manager_browsertest.cc ('k') | chrome/browser/task_management/task_manager_observer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698