Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6162)

Unified Diff: chrome/browser/ui/task_manager/task_manager_table_model.cc

Issue 2028753002: Make Task Manager sort more meaningful (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Use a default argument instead of a second ctor. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/task_manager/task_manager_table_model.cc
diff --git a/chrome/browser/ui/task_manager/task_manager_table_model.cc b/chrome/browser/ui/task_manager/task_manager_table_model.cc
index 075e2e23eee318cb6b38105d38447a5b90cd0bfb..319591422e18d81ea62b45143304a59eb179ad2d 100644
--- a/chrome/browser/ui/task_manager/task_manager_table_model.cc
+++ b/chrome/browser/ui/task_manager/task_manager_table_model.cc
@@ -421,6 +421,8 @@ int TaskManagerTableModel::CompareValues(int row1,
int column_id) {
switch (column_id) {
case IDS_TASK_MANAGER_TASK_COLUMN:
+ // Sorting by IDS_TASK_MANAGER_TASK_COLUMN gives the model order.
+ return ValueCompare(row1, row2);
afakhry 2016/06/03 17:53:42 Be prepared for a storm of regression bugs saying
ncarter (slow) 2016/06/20 17:40:00 I'll start a thread with UI folks. We definitely h
afakhry 2016/06/22 13:49:46 Acknowledged.
case IDS_TASK_MANAGER_PROFILE_NAME_COLUMN:
return ui::TableModel::CompareValues(row1, row2, column_id);

Powered by Google App Engine
This is Rietveld 408576698