Make Task Manager sort more meaningful

chrome/browser/ui/task_manager/task_manager_table_model.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/task_manager/task_manager_table_model.h"
 
 #include <stddef.h>
 
 #include "base/command_line.h"
 #include "base/i18n/number_formatting.h"
@@ skipping 403 matching lines @@
 void TaskManagerTableModel::SetObserver(
     ui::TableModelObserver* observer) {
   table_model_observer_ = observer;
 }
 
 int TaskManagerTableModel::CompareValues(int row1,
                                          int row2,
                                          int column_id) {
   switch (column_id) {
     case IDS_TASK_MANAGER_TASK_COLUMN:
+      // Sorting by IDS_TASK_MANAGER_TASK_COLUMN gives the model order.
+      return ValueCompare(row1, row2);

[afakhry, 2016/06/03 17:53:42]

Be prepared for a storm of regression bugs saying "sorting by tasks doesn't sort
alphabetically". Have you talked to UX about this?

[ncarter (slow), 2016/06/20 17:40:00]

I'll start a thread with UI folks. We definitely have a few options for ways to
expose the logical sorting.

In the mean time, I've removed this part of the diff (I think the tests will
still pass). We can expose this to the UI as a separate CL.

[afakhry, 2016/06/22 13:49:46]

Acknowledged.

     case IDS_TASK_MANAGER_PROFILE_NAME_COLUMN:
       return ui::TableModel::CompareValues(row1, row2, column_id);
 
     case IDS_TASK_MANAGER_NET_COLUMN:
       return ValueCompare(
           observed_task_manager()->GetNetworkUsage(tasks_[row1]),
           observed_task_manager()->GetNetworkUsage(tasks_[row2]));
 
     case IDS_TASK_MANAGER_CPU_COLUMN:
       return ValueCompare(observed_task_manager()->GetCpuUsage(tasks_[row1]),
@@ skipping 399 matching lines @@
 bool TaskManagerTableModel::IsTaskFirstInGroup(int row_index) const {
   if (row_index == 0)
     return true;
 
   return observed_task_manager()->GetProcessId(tasks_[row_index - 1]) !=
       observed_task_manager()->GetProcessId(tasks_[row_index]);
 }
 
 
 }  // namespace task_management