Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Unified Diff: src/arm64/macro-assembler-arm64.cc

Issue 2028633002: Provide a tagged allocation top pointer. Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Update Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/arm64/macro-assembler-arm64.cc
diff --git a/src/arm64/macro-assembler-arm64.cc b/src/arm64/macro-assembler-arm64.cc
index 0490c388d9bbbb8c79a01639edd58a75abb338a8..0c3f231a3f17e382cbe33350150ec777922f2416 100644
--- a/src/arm64/macro-assembler-arm64.cc
+++ b/src/arm64/macro-assembler-arm64.cc
@@ -3097,9 +3097,6 @@ void MacroAssembler::Allocate(int object_size,
// The top pointer is not updated for allocation folding dominators.
Str(result_end, MemOperand(top_address));
}
-
- // Tag the object.
- ObjectTag(result, result);
}
@@ -3169,7 +3166,7 @@ void MacroAssembler::Allocate(Register object_size, Register result,
if (emit_debug_code()) {
Tst(result_end, kObjectAlignmentMask);
- Check(eq, kUnalignedAllocationInNewSpace);
+ Check(ne, kUnalignedAllocationInNewSpace);
}
Ccmp(result_end, alloc_limit, NoFlag, cc);
@@ -3179,9 +3176,6 @@ void MacroAssembler::Allocate(Register object_size, Register result,
// The top pointer is not updated for allocation folding dominators.
Str(result_end, MemOperand(top_address));
}
-
- // Tag the object.
- ObjectTag(result, result);
}
void MacroAssembler::FastAllocate(int object_size, Register result,
@@ -3214,8 +3208,6 @@ void MacroAssembler::FastAllocate(int object_size, Register result,
// Calculate new top and write it back.
Adds(result_end, result, object_size);
Str(result_end, MemOperand(top_address));
-
- ObjectTag(result, result);
}
void MacroAssembler::FastAllocate(Register object_size, Register result,
@@ -3249,10 +3241,8 @@ void MacroAssembler::FastAllocate(Register object_size, Register result,
if (emit_debug_code()) {
Tst(result_end, kObjectAlignmentMask);
- Check(eq, kUnalignedAllocationInNewSpace);
+ Check(ne, kUnalignedAllocationInNewSpace);
}
-
- ObjectTag(result, result);
}
void MacroAssembler::AllocateTwoByteString(Register result,
« no previous file with comments | « src/arm64/code-stubs-arm64.cc ('k') | src/code-stub-assembler.cc » ('j') | src/heap/spaces.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698