Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(648)

Unified Diff: net/spdy/header_coalescer.cc

Issue 2028473003: Move header-ordering validation from hpack decoder to header validator. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removes tests and HpackDecoder::regular_header_seen_. Adds header validation into HeaderCoalescer. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/spdy/header_coalescer.h ('k') | net/spdy/hpack/hpack_decoder.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/spdy/header_coalescer.cc
diff --git a/net/spdy/header_coalescer.cc b/net/spdy/header_coalescer.cc
index 03357c90dfdc43af9f7aa83c8062f76231c09cc0..71624179d5d293f3ae4b01d5d05f0c2819bae2f9 100644
--- a/net/spdy/header_coalescer.cc
+++ b/net/spdy/header_coalescer.cc
@@ -15,6 +15,15 @@ void HeaderCoalescer::OnHeader(base::StringPiece key, base::StringPiece value) {
return;
}
+ if (key[0] == ':') {
+ if (regular_header_seen_) {
+ error_seen_ = true;
+ return;
+ }
+ } else {
+ regular_header_seen_ = true;
+ }
+
auto iter = headers_.find(key);
if (iter == headers_.end()) {
headers_[key] = value;
« no previous file with comments | « net/spdy/header_coalescer.h ('k') | net/spdy/hpack/hpack_decoder.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698