net/spdy/header_coalescer.h - Issue 2028473003: Move header-ordering validation from hpack decoder to header validator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/spdy/header_coalescer.h

Issue 2028473003: Move header-ordering validation from hpack decoder to header validator. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Removes tests and HpackDecoder::regular_header_seen_. Adds header validation into HeaderCoalescer. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/spdy/header_coalescer.h

diff --git a/net/spdy/header_coalescer.h b/net/spdy/header_coalescer.h

index e699622517d09d70ae8c474de6f0c07e60bc29d4..9b16a8215c18eb4e9a06431611ead3329954f84d 100644

--- a/net/spdy/header_coalescer.h

+++ b/net/spdy/header_coalescer.h

@@ -27,6 +27,7 @@ class NET_EXPORT_PRIVATE HeaderCoalescer : public SpdyHeadersHandlerInterface {

private:

SpdyHeaderBlock headers_;

bool error_seen_ = false;

+ bool regular_header_seen_ = false;

};

} // namespace net

« no previous file with comments | « no previous file | net/spdy/header_coalescer.cc » ('j') | net/spdy/header_coalescer.cc » ('J')