Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Unified Diff: net/spdy/hpack/hpack_decoder.cc

Issue 2028473003: Move header-ordering validation from hpack decoder to header validator. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/spdy/hpack/hpack_decoder_test.cc » ('j') | net/spdy/hpack/hpack_decoder_test.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/spdy/hpack/hpack_decoder.cc
diff --git a/net/spdy/hpack/hpack_decoder.cc b/net/spdy/hpack/hpack_decoder.cc
index e8f3f263915178e6c62a78600d837d5a5aa43ed2..da4ef0923e2262da0bcf292303593ca808d7ee0b 100644
--- a/net/spdy/hpack/hpack_decoder.cc
+++ b/net/spdy/hpack/hpack_decoder.cc
@@ -101,17 +101,6 @@ bool HpackDecoder::HandleHeaderRepresentation(StringPiece name,
StringPiece value) {
total_header_bytes_ += name.size() + value.size();
- // Fail if pseudo-header follows regular header.
- if (name.size() > 0) {
- if (name[0] == kPseudoHeaderPrefix) {
- if (regular_header_seen_) {
Bence 2016/05/31 15:57:01 Please also remove regular_header_seen_ member fro
- return false;
- }
- } else {
- regular_header_seen_ = true;
- }
- }
-
if (handler_ == nullptr) {
auto it = decoded_block_.find(name);
if (it == decoded_block_.end()) {
« no previous file with comments | « no previous file | net/spdy/hpack/hpack_decoder_test.cc » ('j') | net/spdy/hpack/hpack_decoder_test.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698