Move header-ordering validation from hpack decoder to header validator.

net/spdy/hpack/hpack_decoder.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/spdy/hpack/hpack_decoder.h"
 
 #include <utility>
 
 #include "base/logging.h"
 #include "net/spdy/hpack/hpack_constants.h"
@@ skipping 83 matching lines @@
   total_parsed_bytes_ = 0;
   header_block_started_ = false;
   handler_ = nullptr;
   return true;
 }
 
 bool HpackDecoder::HandleHeaderRepresentation(StringPiece name,
                                               StringPiece value) {
   total_header_bytes_ += name.size() + value.size();
 
-  // Fail if pseudo-header follows regular header.
-  if (name.size() > 0) {
-    if (name[0] == kPseudoHeaderPrefix) {
-      if (regular_header_seen_) {

[Bence, 2016/05/31 15:57:01]

Please also remove regular_header_seen_ member from header file.

-        return false;
-      }
-    } else {
-      regular_header_seen_ = true;
-    }
-  }
-
   if (handler_ == nullptr) {
     auto it = decoded_block_.find(name);
     if (it == decoded_block_.end()) {
       // This is a new key.
       decoded_block_[name] = value;
     } else {
       // The key already exists, append |value| with appropriate delimiter.
       string new_value = it->second.as_string();
       new_value.append((name == kCookieKey) ? "; " : string(1, '\0'));
       value.AppendToString(&new_value);
@@ skipping 150 matching lines @@
     *output = StringPiece(*buffer);
     return result;
   }
   if (input_stream->MatchPrefixAndConsume(kStringLiteralIdentityEncoded)) {
     return input_stream->DecodeNextIdentityString(output);
   }
   return false;
 }
 
 }  // namespace net