Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Unified Diff: media/base/android/media_codec_util.cc

Issue 2028433002: blacklist some devices with buggy MediaCodec support (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/android/media_codec_util.cc
diff --git a/media/base/android/media_codec_util.cc b/media/base/android/media_codec_util.cc
index c01aabe826be829edcca7d7a4cc1461b2bdccdc9..a776dd139804f3edb6f470856d4a38ec5a04048a 100644
--- a/media/base/android/media_codec_util.cc
+++ b/media/base/android/media_codec_util.cc
@@ -89,11 +89,27 @@ bool MediaCodecUtil::IsMediaCodecAvailable() {
// MediaCodec is only available on JB and greater.
if (base::android::BuildInfo::GetInstance()->sdk_int() < 16)
return false;
+
+ // Blacklist some devices on Jellybean-MR2 as for MediaCodec support is buggy.
+ // http://crbug.com/615872
+ if (base::android::BuildInfo::GetInstance()->sdk_int() == 18) {
liberato (no reviews please) 2016/05/31 15:37:08 i'd be surprised if api level 17 (JB MR1) weren't
+ std::string model(base::android::BuildInfo::GetInstance()->model());
+ return model != "GT-I9100" && model != "GT-I9300" && model != "GT-N7100";
+ }
+
+ // Blacklist some devices on KitKat as for MediaCodec support is buggy.
+ // http://crbug.com/615872
+ if (base::android::BuildInfo::GetInstance()->sdk_int() == 19) {
+ std::string model(base::android::BuildInfo::GetInstance()->model());
+ return model != "GT-I9100" && model != "GT-I9300" && model != "GT-N7100";
+ }
+
// Blacklist some devices on Jellybean as for MediaCodec support is buggy.
// http://crbug.com/365494.
if (base::android::BuildInfo::GetInstance()->sdk_int() == 16) {
std::string model(base::android::BuildInfo::GetInstance()->model());
- return model != "GT-I9100" && model != "GT-I9300" && model != "GT-N7000";
+ return model != "GT-I9100" && model != "GT-I9300" && model != "GT-N7000"
+ && model != "GT-N7100";
}
return true;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698