blacklist some devices with buggy MediaCodec support

media/base/android/media_codec_util.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/base/android/media_codec_util.h"
 
 #include <stddef.h>
 
 #include <algorithm>
 
@@ skipping 71 matching lines @@
   ScopedJavaLocalRef<jstring> j_mime =
       ConvertUTF8ToJavaString(env, android_mime_type);
   return Java_MediaCodecUtil_isDecoderSupportedForDevice(env, j_mime.obj());
 }
 
 // static
 bool MediaCodecUtil::IsMediaCodecAvailable() {
   // MediaCodec is only available on JB and greater.
   if (base::android::BuildInfo::GetInstance()->sdk_int() < 16)
     return false;
+
+  // Blacklist some devices on Jellybean-MR2 as for MediaCodec support is buggy.
+  // http://crbug.com/615872
+  if (base::android::BuildInfo::GetInstance()->sdk_int() == 18) {

[liberato (no reviews please), 2016/05/31 15:37:08]

i'd be surprised if api level 17 (JB MR1) weren't also broken.

please merge all three conditionals into one check for api <= 19.  it's probably
also safe to include the N7000 in there, unless you know that it works on > 16. 
that might be the most recent official update anyway.

+    std::string model(base::android::BuildInfo::GetInstance()->model());
+    return model != "GT-I9100" && model != "GT-I9300" && model != "GT-N7100";
+  }
+
+  // Blacklist some devices on KitKat as for MediaCodec support is buggy.
+  // http://crbug.com/615872
+  if (base::android::BuildInfo::GetInstance()->sdk_int() == 19) {
+    std::string model(base::android::BuildInfo::GetInstance()->model());
+    return model != "GT-I9100" && model != "GT-I9300" && model != "GT-N7100";
+  }
+
   // Blacklist some devices on Jellybean as for MediaCodec support is buggy.
   // http://crbug.com/365494.
   if (base::android::BuildInfo::GetInstance()->sdk_int() == 16) {
     std::string model(base::android::BuildInfo::GetInstance()->model());
-    return model != "GT-I9100" && model != "GT-I9300" && model != "GT-N7000";
+    return model != "GT-I9100" && model != "GT-I9300" && model != "GT-N7000"
+        && model != "GT-N7100";
   }
   return true;
 }
 
 // static
 bool MediaCodecUtil::SupportsSetParameters() {
   // MediaCodec.setParameters() is only available starting with K.
   return base::android::BuildInfo::GetInstance()->sdk_int() >= 19;
 }
 
@@ skipping 130 matching lines @@
     if (base::StartsWith(model, model_prefixes[i],
                          base::CompareCase::INSENSITIVE_ASCII)) {
       return false;
     }
   }
 
   return true;
 }
 
 }  // namespace media