Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Issue 2028433002: blacklist some devices with buggy MediaCodec support (Closed)

Created:
4 years, 6 months ago by pavor
Modified:
4 years, 6 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, avayvod+watch_chromium.org, mlamouri+watch-media_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

blacklist some devices with buggy MediaCodec support Some old Samsung devices have buggy support for MediaCodec, better fallback to MediaPlayer for them. BUG=615872 R=qinmin@chromium.org,liberato@chromium.org TEST=Play several youtube videos sequentially in the same tab on Samsung Galaxy S3 phone Committed: https://crrev.com/9be4e3ddeb502d38b2ec1479d8840220170b255b Cr-Commit-Position: refs/heads/master@{#398631}

Patch Set 1 #

Total comments: 1

Patch Set 2 : blacklist some devices with buggy MediaCodec support #

Total comments: 1

Patch Set 3 : blacklist some devices with buggy MediaCodec support #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M media/base/android/media_codec_util.cc View 1 2 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
pavor
4 years, 6 months ago (2016-05-30 16:45:46 UTC) #1
liberato (no reviews please)
i'm going to see if i can find similar crashes. my first quick search showed ...
4 years, 6 months ago (2016-05-31 15:37:08 UTC) #2
pavor
On 2016/05/31 15:37:08, liberato wrote: > i'm going to see if i can find similar ...
4 years, 6 months ago (2016-05-31 16:33:07 UTC) #3
liberato (no reviews please)
lgtm. sorry for the delay.
4 years, 6 months ago (2016-06-08 17:04:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2028433002/20001
4 years, 6 months ago (2016-06-08 17:06:37 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/197199)
4 years, 6 months ago (2016-06-08 17:14:08 UTC) #8
qinmin
https://codereview.chromium.org/2028433002/diff/20001/media/base/android/media_codec_util.cc File media/base/android/media_codec_util.cc (right): https://codereview.chromium.org/2028433002/diff/20001/media/base/android/media_codec_util.cc#newcode98 media/base/android/media_codec_util.cc:98: && model != "GT-N7100"; nit: && should go to ...
4 years, 6 months ago (2016-06-08 17:18:07 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2028433002/40001
4 years, 6 months ago (2016-06-08 17:41:24 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-06-08 19:06:56 UTC) #13
commit-bot: I haz the power
4 years, 6 months ago (2016-06-08 19:09:07 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/9be4e3ddeb502d38b2ec1479d8840220170b255b
Cr-Commit-Position: refs/heads/master@{#398631}

Powered by Google App Engine
This is Rietveld 408576698