blacklist some devices with buggy MediaCodec support

blacklist some devices with buggy MediaCodec support

Some old Samsung devices have buggy support for MediaCodec, better fallback to MediaPlayer for them.

BUG=615872
R=qinmin@chromium.org,liberato@chromium.org
TEST=Play several youtube videos sequentially in the same tab on Samsung Galaxy S3 phone

Committed: https://crrev.com/9be4e3ddeb502d38b2ec1479d8840220170b255b
Cr-Commit-Position: refs/heads/master@{#398631}

[liberato (no reviews please), 2016-05-31 15:37:08]

i'm going to see if i can find similar crashes.  my first quick search showed
nothing, which confuses me.

thanks
-fl

https://codereview.chromium.org/2028433002/diff/1/media/base/android/media_co...
File media/base/android/media_codec_util.cc (right):

https://codereview.chromium.org/2028433002/diff/1/media/base/android/media_co...
media/base/android/media_codec_util.cc:95: if
(base::android::BuildInfo::GetInstance()->sdk_int() == 18) {
i'd be surprised if api level 17 (JB MR1) weren't also broken.

please merge all three conditionals into one check for api <= 19.  it's probably
also safe to include the N7000 in there, unless you know that it works on > 16. 
that might be the most recent official update anyway.

[pavor, 2016-05-31 16:33:07]

On 2016/05/31 15:37:08, liberato wrote:
> i'm going to see if i can find similar crashes.  my first quick search showed
> nothing, which confuses me.
> 
> thanks
> -fl
> 
>
https://codereview.chromium.org/2028433002/diff/1/media/base/android/media_co...
> File media/base/android/media_codec_util.cc (right):
> 
>
https://codereview.chromium.org/2028433002/diff/1/media/base/android/media_co...
> media/base/android/media_codec_util.cc:95: if
> (base::android::BuildInfo::GetInstance()->sdk_int() == 18) {
> i'd be surprised if api level 17 (JB MR1) weren't also broken.
> 
> please merge all three conditionals into one check for api <= 19.  it's
probably
> also safe to include the N7000 in there, unless you know that it works on >
16. 
> that might be the most recent official update anyway.

I can merge it. In this patch there are all combinations of OS/Model that I have
seen with the crash. For some models there is no firmware with api less than
some version.
This is one of the few bugs that I could easily reproduce on device, I used
Samsung Galaxy S3 with Android 4.4.4 to debug it, but I also saw the same bug on
other SGS3 with Android 4.3.
I will attach logcat output of chrome to the bug report, I don't know whether it
has some id in it which you can lookup in some crash reporting tool, but I hope
it helps.

[liberato (no reviews please), 2016-06-08 17:04:31]

lgtm.  sorry for the delay.

[pavor, 2016-06-08 17:06:12]

The CQ bit was checked by pavor@yandex-team.ru

[commit-bot: I haz the power, 2016-06-08 17:06:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2028433002/20001

[commit-bot: I haz the power, 2016-06-08 17:14:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-08 17:14:08]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[qinmin, 2016-06-08 17:18:07]

https://codereview.chromium.org/2028433002/diff/20001/media/base/android/medi...
File media/base/android/media_codec_util.cc (right):

https://codereview.chromium.org/2028433002/diff/20001/media/base/android/medi...
media/base/android/media_codec_util.cc:98: && model != "GT-N7100";
nit: && should go to the previous line

[pavor, 2016-06-08 17:41:05]

The CQ bit was checked by pavor@yandex-team.ru

[pavor, 2016-06-08 17:41:06]

The patchset sent to the CQ was uploaded after l-g-t-m from
liberato@chromium.org
Link to the patchset: https://codereview.chromium.org/2028433002/#ps40001
(title: "blacklist some devices with buggy MediaCodec support")

[commit-bot: I haz the power, 2016-06-08 17:41:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2028433002/40001

[commit-bot: I haz the power, 2016-06-08 19:06:56]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-08 19:09:06]

Description was changed from

==========
blacklist some devices with buggy MediaCodec support

Some old Samsung devices have buggy support for MediaCodec, better fallback to
MediaPlayer for them.

BUG=615872
R=qinmin@chromium.org,liberato@chromium.org
TEST=Play several youtube videos sequentially in the same tab on Samsung Galaxy
S3 phone
==========

to

==========
blacklist some devices with buggy MediaCodec support

Some old Samsung devices have buggy support for MediaCodec, better fallback to
MediaPlayer for them.

BUG=615872
R=qinmin@chromium.org,liberato@chromium.org
TEST=Play several youtube videos sequentially in the same tab on Samsung Galaxy
S3 phone

Committed: https://crrev.com/9be4e3ddeb502d38b2ec1479d8840220170b255b
Cr-Commit-Position: refs/heads/master@{#398631}
==========

[commit-bot: I haz the power, 2016-06-08 19:09:07]

Patchset 3 (id:??) landed as
https://crrev.com/9be4e3ddeb502d38b2ec1479d8840220170b255b
Cr-Commit-Position: refs/heads/master@{#398631}