Issue 2028373002: [Media Router WebUI] Delay putSearchAtBottom_() until after imports

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2028373002: [Media Router WebUI] Delay putSearchAtBottom_() until after imports (Closed)

Created:
4 years, 6 months ago by btolsch

Modified:
4 years, 6 months ago

Reviewers:
apacible

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2743

Target Ref:
refs/pending/branch-heads/2743

Project:
chromium

Visibility:
Public.

More Reviews

Description

[Media Router WebUI] Delay putSearchAtBottom_() until after imports This change ensures that a call to putSearchAtBottom_() is made after all the html imports have been completed. This should ensure that the reference to search.offsetHeight is not zero when it sets margins and padding. BUG=614209, 609350 R=apacible@chromium.org NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2008393002 Cr-Commit-Position: refs/heads/master@{#396244} (cherry picked from commit 39dfd062d8014833796a544e4b778ed811b98325)

Patch Set 1 #

Created: 4 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js	View		2 chunks	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2028373002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2028373002/1

4 years, 6 months ago (2016-06-01 23:03:13 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages